Skip to content
This repository has been archived by the owner on Dec 10, 2024. It is now read-only.

add 'name' and 'description' to project hooks structs #2069

Conversation

cgahlon
Copy link
Contributor

@cgahlon cgahlon commented Nov 28, 2024

Adds the name and description fields to the ProjectHook, AddProjectHookOptions, and EditProjectHookOptions structs. These fields are supported by the GitLab 17.x API. Also added them to the existing test.

I have been using this code in my fork to automatically generate hooks without any issues. Thanks for all your work on this project!

GitLab 17.x API now supports 'name' and 'description' fields

Added fields and updates tests.
Copy link
Contributor

@RicePatrick RicePatrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change, otherwise I think we're good to merge. I'll kick off the actions as well to validate linting and tests.

projects.go Outdated Show resolved Hide resolved
Copy link
Contributor

@RicePatrick RicePatrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; merging!

@RicePatrick RicePatrick merged commit 35c2003 into xanzy:main Nov 29, 2024
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants