This repository has been archived by the owner on Dec 10, 2024. It is now read-only.
Add support for hidden field to group variables #2064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timofurrer
previously requested changes
Nov 21, 2024
There was a problem hiding this comment.
@yogeshlonkar thanks for the contribution 🤝
I've left some clarification questions similar to the ones I've left in the other PR #2065.
Back to you 🏓
yogeshlonkar
changed the title
GitLab has inconsistent naming of the filed for hidden variables. It seems for keeping UI consistent, GitLab chose to introduce different naming for the same field. This could have been easy handled in UI by setting two variables on API request instead of introducing combined field for UI. I have added 2 test cases for create and update project API as per the gitlab.com API that I also manually tested.
yogeshlonkar
changed the title
|
Thanks for fixing the models for group to align with the models for project. Merging so this is available during the migration :) |
RicePatrick
approved these changes
Dec 9, 2024
RicePatrick
dismissed
timofurrer’s stale review
Comments fixed as part of a subsequent commit to align to projects in separate PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.