Allow .xml suffix and set correct Content-Type header #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/xantiagoma/zealusercontributions/5m4pq4vgp |
|
You can see both features in action by going to https://zealusercontributions-git-fork-jmerle-feature-xml.xantiagoma.vercel.app/api/docsets/PlantUML.xml in the browser and by comparing it to https://zealusercontributions.now.sh/api/docsets/PlantUML.xml. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a fix for zealdocs/zeal#1240 to this repository. In the current Zeal release all feed urls are assumed to have a
.xmlsuffix, which this PR adds support for. Although it is nice that this assumption in Zeal will go away in the 0.7.0 release, at the moment it is impossible to use this project with the latest release of Zeal.Besides that this PR sets the correct
Content-Typeheader on API responses which return XML, so that browsers print the XML in a nicer way when manually going to any of those API endpoints.