[msbuild] Add support for Metal in the simulator. Fixes #7392. (#7983) #7991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and watchOS to a few tasks. Fixes dotnet#6200. (dotnet#7226) The problem with dotnet#6200 was that we'd pass -mios-version-min=x.y to the metal tool even for tvOS apps. This fixes it so that now pass -mtvos-version-min. Fixes dotnet#6200.
rolfbjarne
requested review from
chamons,
emaf,
jstedfast,
kzu and
VincentDondain
as code owners
rolfbjarne
added
enhancement
|
Build success |
mandel-macaque
approved these changes
Feb 27, 2020
dalexsoto
approved these changes
Feb 27, 2020
spouliot
approved these changes
Feb 27, 2020
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #7983.
This also requires a backport of #7226:
[msbuild] Provide the correct value for the operating system for tvOS and
watchOS to a few tasks. Fixes #6200. (#7226)
The problem with #6200 was that we'd pass -mios-version-min=x.y to the metal
tool even for tvOS apps. This fixes it so that now pass -mtvos-version-min.
Fixes #6200.