[msbuild] Stub out GenerateManifests to prevent Windows ClickOnce target collisions #7668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…get collisions - https://devdiv.visualstudio.com/DevDiv/_queries/edit/1041456/ - On Windows the GenerateManifests target will sometimes run and do the wrong thing as we overload their usages of @(NativeReference). Stub it as a no-op
chamons
requested review from
emaf,
jstedfast,
rolfbjarne and
VincentDondain
as code owners
chamons
added
run-mmp-tests
|
Looking for 👍 from someone from VS team before moving forward, unsure on stub for ResolveNativeReference I'm seeing on Windows and not in our msbuild. |
|
Build failure Test results3 tests failed, 86 tests passed.Failed tests
|
|
I'm now reworking to include the other XVS stubs as well. |
|
Build failure Test results1 tests failed, 88 tests passed.Failed tests
|
kzu
suggested changes
Jan 3, 2020
msbuild/Xamarin.iOS.Tasks.Core/Xamarin.iOS.NativeReference.Stubs.targets
Outdated
Show resolved
Hide resolved
|
Build failure Test results1 tests failed, 88 tests passed.Failed tests
|
emaf
approved these changes
Jan 6, 2020
rolfbjarne
approved these changes
Jan 7, 2020
|
Only failure is HE0038. Just waiting on @kzu 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as we overload their usages of @(NativeReference). Stub it as a no-op