[Fix] Add missing selectors for NSExpression. #57
+225
−29
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,168 @@ | ||
| // TODO: The NSExpression class is a cluster class in cococa. This means that now all the properties are supported by all the types of NSExpressions. | ||
| // At the point of this written all the properties have been tested with all types EXCEPT NSExpressionType.Subquery and NSExpressionType.Conditional because writting | ||
| // tests for those was not possible. The properties for these two types have been deduced from the other types yet bugs are possible and an objc excection will be thrown. | ||
| using System; | ||
| using System.Runtime.InteropServices; | ||
| using XamCore.ObjCRuntime; | ||
|
|
||
| namespace XamCore.Foundation { | ||
|
|
||
| public partial class NSExpression { | ||
|
|
||
| [Export ("arguments")] | ||
| public virtual NSExpression[] Arguments { | ||
| get { | ||
| var type = ExpressionType; | ||
| if (type != NSExpressionType.Function && type != NSExpressionType.Block && type != NSExpressionType.KeyPath) | ||
| throw new InvalidOperationException ( | ||
| $"NSExpressions of type {type} do not support the Arguments property. Expressions that support the property " | ||
| + "are of type Function, Block and KeyPath"); | ||
| return _Arguments; | ||
| } | ||
| } | ||
|
|
||
|
|
||
| [Export ("collection")] | ||
| public virtual NSObject Collection { | ||
| get { | ||
| var type = ExpressionType; | ||
| if (type != NSExpressionType.NSAggregate) | ||
| throw new InvalidOperationException ( | ||
| $"NSExpressions of type {type} do not support the Collection property. Expressions that support the property " | ||
| + "are of type NSAggregate"); | ||
| return _Collection; | ||
| } | ||
| } | ||
|
|
||
| [Export ("predicate")] | ||
| public virtual NSPredicate Predicate { | ||
| get { | ||
| var type = ExpressionType; | ||
| if (type != NSExpressionType.Conditional && type != NSExpressionType.Subquery) | ||
| throw new InvalidOperationException ( | ||
| $"NSExpressions of type {type} do not support the Predicate property. Expressions that support the property " | ||
| + "are of type Conditional and Subquery"); | ||
| return _Predicate; | ||
| } | ||
| } | ||
|
|
||
| [Export ("expressionBlock")] | ||
| public virtual NSExpressionCallbackHandler Block { | ||
| get { | ||
| if (ExpressionType != NSExpressionType.Block) | ||
| throw new InvalidOperationException ( | ||
| $"NSExpressions of type {ExpressionType} do not support the Block property. Expressions that support the property " | ||
| + "are created via the FromFunction (NSExpressionHandler target, NSExpression[] parameters) method."); | ||
| return _Block; | ||
| } | ||
| } | ||
|
|
||
| [Export ("constantValue")] | ||
| public virtual NSObject ConstantValue { | ||
| get { | ||
| if (ExpressionType != NSExpressionType.ConstantValue) | ||
| throw new InvalidOperationException ( | ||
| $"NSExpressions of type {ExpressionType} do not support the ConstantValue property. Expressions that support the property " | ||
| + "are created via the FromConstant methods."); | ||
| return _ConstantValue; | ||
| } | ||
| } | ||
|
|
||
| [Export ("keyPath")] | ||
| public virtual string KeyPath { | ||
| get { | ||
| if (ExpressionType != NSExpressionType.KeyPath) | ||
| throw new InvalidOperationException ( | ||
| $"NSExpressions of type {ExpressionType} do not support the KeyPath property. Expressions that support the property " | ||
| + "are created via the FromKeyPath method."); | ||
| return _KeyPath; | ||
| } | ||
| } | ||
|
|
||
| [Export ("leftExpression")] | ||
| public virtual NSExpression LeftExpression { | ||
| get { | ||
| var type = ExpressionType; | ||
| if (type != NSExpressionType.Conditional && type != NSExpressionType.IntersectSet && type != NSExpressionType.MinusSet | ||
| && type != NSExpressionType.Subquery && type != NSExpressionType.UnionSet) | ||
| throw new InvalidOperationException ( | ||
| $"NSExpressions of type {type} do not support the LeftExpression property. Expressions that support the property " | ||
| + "are of type Conditional, IntersectSet, MinusSet, Subquery or UnionSet"); | ||
| return _LeftExpression; | ||
| } | ||
| } | ||
|
|
||
| [Mac(10,11),iOS(9,0)] | ||
| [Export ("trueExpression")] | ||
| public virtual NSExpression TrueExpression { | ||
| get { | ||
| var type = ExpressionType; | ||
| if (type != NSExpressionType.Conditional && type != NSExpressionType.Subquery) | ||
| throw new InvalidOperationException ( | ||
| $"NSExpressions of type {type} do not support the TrueExpression property. Expressions that support the property " | ||
| + "are of type Conditional and Subquery"); | ||
| return _TrueExpression; | ||
| } | ||
| } | ||
|
|
||
| [Mac(10,11),iOS(9,0)] | ||
| [Export ("falseExpression")] | ||
| public virtual NSExpression FalseExpression { | ||
| get { | ||
| var type = ExpressionType; | ||
| if (type != NSExpressionType.Conditional && type != NSExpressionType.Subquery) | ||
| throw new InvalidOperationException ( | ||
| $"NSExpressions of type {type} do not support the FalseExpression property. Expressions that support the property " | ||
| + "are of type Conditional and Subquery"); | ||
| return _FalseExpression; | ||
| } | ||
| } | ||
|
|
||
| [Export ("rightExpression")] | ||
| public virtual NSExpression RightExpression { | ||
| get { | ||
| var type = ExpressionType; | ||
| if (type != NSExpressionType.Conditional && type != NSExpressionType.IntersectSet && type != NSExpressionType.MinusSet | ||
| && type != NSExpressionType.Subquery && type != NSExpressionType.UnionSet) | ||
| throw new InvalidOperationException ( | ||
| $"NSExpressions of type {type} do not support the RightExpression property. Expressions that support the property " | ||
| + "are of type Conditional, IntersectSet, MinusSet, Subquery or UnionSet"); | ||
| return _RightExpression; | ||
| } | ||
| } | ||
|
|
||
| [Export ("function")] | ||
| public virtual string Function { | ||
| get { | ||
| if (ExpressionType != NSExpressionType.Function) | ||
| throw new InvalidOperationException ( | ||
| $"NSExpressions of type {ExpressionType} do not support the Function property. Expressions that support the property " | ||
| + "are created via the FromFunction (FromFunction (string name, NSExpression[] parameters) or FromFormat methods."); | ||
| return _Function; | ||
| } | ||
| } | ||
|
|
||
| [Export ("variable")] | ||
| public virtual string Variable { | ||
| get { | ||
| if (ExpressionType != NSExpressionType.Variable) | ||
| throw new InvalidOperationException ( | ||
| $"NSExpressions of type {ExpressionType} do not support the Function property. Expressions that support the property " | ||
| + "are created via the FromVariable method."); | ||
| return _Variable; | ||
| } | ||
| } | ||
|
|
||
| [Export ("operand")] | ||
| public virtual NSExpression Operand { | ||
| get { | ||
| var type = ExpressionType; | ||
| if (type != NSExpressionType.KeyPath && type != NSExpressionType.Function) | ||
| throw new InvalidOperationException ( | ||
| $"NSExpressions of type {type} do not support the Arguments property. Expressions that support the property " | ||
| + "are of type Function, Block and KeyPath"); | ||
| return _Operand; | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since it's unused by Xamarin.*.dll, except for obsolete API, it should be:
[Obsolete]attribute, so external usage of the delegate trigger warnings (and code reviews);#if !XAMCORE_4_0block so our next, if ever, breaking changes release can drop it;