From 5d418bca55d1222ae3c8dac776d7413a1151e433 Mon Sep 17 00:00:00 2001 From: Timothy Risi Date: Tue, 6 Jun 2017 21:34:34 -0800 Subject: [PATCH 01/13] New FinderSync bindings --- src/findersync.cs | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/src/findersync.cs b/src/findersync.cs index 7292fde77cb3..da92d894bf80 100644 --- a/src/findersync.cs +++ b/src/findersync.cs @@ -27,6 +27,20 @@ interface FIFinderSyncController : NSSecureCoding, NSCopying [NullAllowed, Export ("selectedItemURLs")] NSUrl[] SelectedItemURLs { get; } + + [Export ("lastUsedDateForItemWithURL:")] + [return: NullAllowed] + NSDate GetLastUsedDateForItem (NSUrl itemURL); + + [Export ("setLastUsedDate:forItemWithURL:completion:")] + void SetLastUsedDate (NSDate lastUsedDate, NSUrl itemURL, Action completion); + + [Export ("tagDataForItemWithURL:")] + [return: NullAllowed] + NSData GetTagDataForItem (NSUrl itemURL); + + [Export ("setTagData:forItemWithURL:completion:")] + void SetTagData ([NullAllowed] NSData tagData, NSUrl itemURL, Action completion); } [Mac (10, 10, onlyOn64: true)] @@ -54,6 +68,21 @@ interface FIFinderSyncProtocol [Export ("toolbarItemToolTip")] string ToolbarItemToolTip { get; } + + [Export ("supportedMessageInterfaceNamesForItemWithURL:")] + string[] GetSupportedMessageInterfaceNamesForItem (NSUrl itemURL); + + // @optional -(Protocol * _Nonnull)protocolForMessageInterface:(NSFileProviderMessageInterface * _Nonnull)messageInterface; + [Export ("protocolForMessageInterface:")] + Protocol GetProtocol (NSFileProviderMessageInterface messageInterface); + + // @optional -(id _Nonnull)exportedObjectForMessageInterface:(NSFileProviderMessageInterface * _Nonnull)messageInterface itemURL:(NSURL * _Nonnull)itemURL error:(NSError * _Nullable * _Nullable)error; + [Export ("exportedObjectForMessageInterface:itemURL:error:")] + NSObject GetExportedObject (NSFileProviderMessageInterface messageInterface, NSUrl itemURL, [NullAllowed] out NSError error); + + // @optional -(void)valuesForAttributes:(NSArray * _Nonnull)attributes forItemWithURL:(NSURL * _Nonnull)itemURL completion:(void (^ _Nonnull)(NSDictionary * _Nonnull, NSError * _Nullable))completion; + [Export ("valuesForAttributes:forItemWithURL:completion:")] + void ValuesForAttributes (string[] attributes, NSUrl itemURL, Action, NSError> completion); } [Mac (10, 10, onlyOn64: true)] From 5e2bf0599fe3ef32a3a0c083c18a390dae2ca9a3 Mon Sep 17 00:00:00 2001 From: Timothy Risi Date: Tue, 6 Jun 2017 23:19:21 -0800 Subject: [PATCH 02/13] Bind MediaLibrary changes. Fix spacing in FinderSync --- src/findersync.cs | 42 +++++++++++++++++++++++------------------- src/medialibrary.cs | 12 ++++++++++++ 2 files changed, 35 insertions(+), 19 deletions(-) diff --git a/src/findersync.cs b/src/findersync.cs index da92d894bf80..779e3ec54a47 100644 --- a/src/findersync.cs +++ b/src/findersync.cs @@ -28,19 +28,23 @@ interface FIFinderSyncController : NSSecureCoding, NSCopying [NullAllowed, Export ("selectedItemURLs")] NSUrl[] SelectedItemURLs { get; } - [Export ("lastUsedDateForItemWithURL:")] - [return: NullAllowed] - NSDate GetLastUsedDateForItem (NSUrl itemURL); + [Mac (10,13, onlyOn64 : true)] + [Export ("lastUsedDateForItemWithURL:")] + [return: NullAllowed] + NSDate GetLastUsedDateForItem (NSUrl itemURL); - [Export ("setLastUsedDate:forItemWithURL:completion:")] - void SetLastUsedDate (NSDate lastUsedDate, NSUrl itemURL, Action completion); + [Mac (10,13, onlyOn64 : true)] + [Export ("setLastUsedDate:forItemWithURL:completion:")] + void SetLastUsedDate (NSDate lastUsedDate, NSUrl itemURL, Action completion); - [Export ("tagDataForItemWithURL:")] - [return: NullAllowed] - NSData GetTagDataForItem (NSUrl itemURL); + [Mac (10,13, onlyOn64 : true)] + [Export ("tagDataForItemWithURL:")] + [return: NullAllowed] + NSData GetTagDataForItem (NSUrl itemURL); - [Export ("setTagData:forItemWithURL:completion:")] - void SetTagData ([NullAllowed] NSData tagData, NSUrl itemURL, Action completion); + [Mac (10,13, onlyOn64 : true)] + [Export ("setTagData:forItemWithURL:completion:")] + void SetTagData ([NullAllowed] NSData tagData, NSUrl itemURL, Action completion); } [Mac (10, 10, onlyOn64: true)] @@ -72,17 +76,17 @@ interface FIFinderSyncProtocol [Export ("supportedMessageInterfaceNamesForItemWithURL:")] string[] GetSupportedMessageInterfaceNamesForItem (NSUrl itemURL); - // @optional -(Protocol * _Nonnull)protocolForMessageInterface:(NSFileProviderMessageInterface * _Nonnull)messageInterface; - [Export ("protocolForMessageInterface:")] - Protocol GetProtocol (NSFileProviderMessageInterface messageInterface); + [Mac (10,13, onlyOn64 : true)] + [Export ("protocolForMessageInterface:")] + Protocol GetProtocol (NSFileProviderMessageInterface messageInterface); - // @optional -(id _Nonnull)exportedObjectForMessageInterface:(NSFileProviderMessageInterface * _Nonnull)messageInterface itemURL:(NSURL * _Nonnull)itemURL error:(NSError * _Nullable * _Nullable)error; - [Export ("exportedObjectForMessageInterface:itemURL:error:")] - NSObject GetExportedObject (NSFileProviderMessageInterface messageInterface, NSUrl itemURL, [NullAllowed] out NSError error); + [Mac (10,13, onlyOn64 : true)] + [Export ("exportedObjectForMessageInterface:itemURL:error:")] + NSObject GetExportedObject (NSFileProviderMessageInterface messageInterface, NSUrl itemURL, [NullAllowed] out NSError error); - // @optional -(void)valuesForAttributes:(NSArray * _Nonnull)attributes forItemWithURL:(NSURL * _Nonnull)itemURL completion:(void (^ _Nonnull)(NSDictionary * _Nonnull, NSError * _Nullable))completion; - [Export ("valuesForAttributes:forItemWithURL:completion:")] - void ValuesForAttributes (string[] attributes, NSUrl itemURL, Action, NSError> completion); + [Mac (10,13, onlyOn64 : true)] + [Export ("valuesForAttributes:forItemWithURL:completion:")] + void ValuesForAttributes (string[] attributes, NSUrl itemURL, Action, NSError> completion); } [Mac (10, 10, onlyOn64: true)] diff --git a/src/medialibrary.cs b/src/medialibrary.cs index a64bb31a90d8..53b161d61e29 100644 --- a/src/medialibrary.cs +++ b/src/medialibrary.cs @@ -156,6 +156,18 @@ interface MediaLibraryTypeIdentifierKey { [Field ("MLPhotosFrontCameraGroupTypeIdentifier")] NSString PhotosFrontCameraGroupTypeIdentifier { get; } + [Mac (10,13, onlyOn64 : true)] + [Field ("MLPhotosLivePhotosGroupTypeIdentifier")] + string MLPhotosLivePhotosGroupTypeIdentifier { get; } + + [Mac (10,13, onlyOn64 : true)] + [Field ("MLPhotosLongExposureGroupTypeIdentifier")] + string MLPhotosLongExposureGroupTypeIdentifier { get; } + + [Mac (10,13, onlyOn64 : true)] + [Field ("MLPhotosAnimatedGroupTypeIdentifier")] + string MLPhotosAnimatedGroupTypeIdentifier { get; } + [Mac (10,10, onlyOn64 : true)] [Field ("MLPhotosPanoramasGroupTypeIdentifier")] NSString PhotosPanoramasGroupTypeIdentifier { get; } From 5a358e7f410628d27837d889db738784cb3bbf90 Mon Sep 17 00:00:00 2001 From: Timothy Risi Date: Wed, 7 Jun 2017 10:05:14 -0800 Subject: [PATCH 03/13] Add 2 unbound frameworks to the xtro mac exclusions --- tests/xtro-sharpie/Runner.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/xtro-sharpie/Runner.cs b/tests/xtro-sharpie/Runner.cs index 2f93f4906bc5..40fa9c6b4d84 100644 --- a/tests/xtro-sharpie/Runner.cs +++ b/tests/xtro-sharpie/Runner.cs @@ -60,7 +60,7 @@ class ModuleExclusionList { "IOBluetooth", "IOBluetoothUI", "PubSub", "CryptoTokenKit", "DiscRecording", "DiscRecordingUI", "ImageCaptureCore", "OSAKit", "AudioVideoBridging", "Automator", "ImageCapture", // Maybe? - "ICADevices", "OpenDirectory", "IMServicePlugIn", "PreferencePanes", "ScreenSaver", + "ICADevices", "OpenDirectory", "IMServicePlugIn", "PreferencePanes", "ScreenSaver", "CoreMediaIO", "SecurityInterface", // Nope "InstallerPlugins", "JavaVM", "ExceptionHandling", "JavaFrameEmbedding", From bef760621b86ef94ce6f0cd14fd4b7c3a9f294dc Mon Sep 17 00:00:00 2001 From: Timothy Risi Date: Wed, 14 Jun 2017 09:01:00 -0800 Subject: [PATCH 04/13] Fix fields to use string, not nsstring --- src/medialibrary.cs | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/medialibrary.cs b/src/medialibrary.cs index 53b161d61e29..0203ad5ec5d0 100644 --- a/src/medialibrary.cs +++ b/src/medialibrary.cs @@ -156,17 +156,17 @@ interface MediaLibraryTypeIdentifierKey { [Field ("MLPhotosFrontCameraGroupTypeIdentifier")] NSString PhotosFrontCameraGroupTypeIdentifier { get; } - [Mac (10,13, onlyOn64 : true)] - [Field ("MLPhotosLivePhotosGroupTypeIdentifier")] - string MLPhotosLivePhotosGroupTypeIdentifier { get; } + [Mac (10,13, onlyOn64 : true)] + [Field ("MLPhotosLivePhotosGroupTypeIdentifier")] + NSString MLPhotosLivePhotosGroupTypeIdentifier { get; } - [Mac (10,13, onlyOn64 : true)] + [Mac (10,13, onlyOn64 : true)] [Field ("MLPhotosLongExposureGroupTypeIdentifier")] - string MLPhotosLongExposureGroupTypeIdentifier { get; } + NSString MLPhotosLongExposureGroupTypeIdentifier { get; } [Mac (10,13, onlyOn64 : true)] [Field ("MLPhotosAnimatedGroupTypeIdentifier")] - string MLPhotosAnimatedGroupTypeIdentifier { get; } + NSString MLPhotosAnimatedGroupTypeIdentifier { get; } [Mac (10,10, onlyOn64 : true)] [Field ("MLPhotosPanoramasGroupTypeIdentifier")] From 061069302a3cfc3f51264331dfb8e69d42984123 Mon Sep 17 00:00:00 2001 From: Timothy Risi Date: Wed, 14 Jun 2017 09:21:08 -0800 Subject: [PATCH 05/13] Add NSFileProviderMessageInterface needed for FinderSync --- src/foundation.cs | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/foundation.cs b/src/foundation.cs index 7930656f1aea..ea1f93eccdfd 100644 --- a/src/foundation.cs +++ b/src/foundation.cs @@ -14206,4 +14206,11 @@ interface NSMeasurementFormatter : NSSecureCoding { string ToString (NSUnit unit); } + [NoWatch, NoTV, Mac (10,13), iOS (11,0)] + [BaseType (typeof(NSObject))] + interface NSFileProviderMessageInterface + { + [Export ("name")] + string Name { get; } + } } From aca289408ddc6b24383e25d8aefaa3ea5eb6f204 Mon Sep 17 00:00:00 2001 From: Timothy Risi Date: Wed, 14 Jun 2017 11:00:39 -0800 Subject: [PATCH 06/13] PR Fixes --- src/findersync.cs | 16 ++++++++-------- src/medialibrary.cs | 6 +++--- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/findersync.cs b/src/findersync.cs index 779e3ec54a47..f597f450b93d 100644 --- a/src/findersync.cs +++ b/src/findersync.cs @@ -31,20 +31,20 @@ interface FIFinderSyncController : NSSecureCoding, NSCopying [Mac (10,13, onlyOn64 : true)] [Export ("lastUsedDateForItemWithURL:")] [return: NullAllowed] - NSDate GetLastUsedDateForItem (NSUrl itemURL); + NSDate GetLastUsedDate (NSUrl itemUrl); [Mac (10,13, onlyOn64 : true)] [Export ("setLastUsedDate:forItemWithURL:completion:")] - void SetLastUsedDate (NSDate lastUsedDate, NSUrl itemURL, Action completion); + void SetLastUsedDate (NSDate lastUsedDate, NSUrl itemUrl, Action completion); [Mac (10,13, onlyOn64 : true)] [Export ("tagDataForItemWithURL:")] [return: NullAllowed] - NSData GetTagDataForItem (NSUrl itemURL); + NSData GetTagData (NSUrl itemUrl); [Mac (10,13, onlyOn64 : true)] [Export ("setTagData:forItemWithURL:completion:")] - void SetTagData ([NullAllowed] NSData tagData, NSUrl itemURL, Action completion); + void SetTagData ([NullAllowed] NSData tagData, NSUrl itemUrl, Action completion); } [Mac (10, 10, onlyOn64: true)] @@ -73,8 +73,8 @@ interface FIFinderSyncProtocol [Export ("toolbarItemToolTip")] string ToolbarItemToolTip { get; } - [Export ("supportedMessageInterfaceNamesForItemWithURL:")] - string[] GetSupportedMessageInterfaceNamesForItem (NSUrl itemURL); + [Export ("supportedMessageInterfaceNamesForItemWithURL:")] + string[] GetSupportedMessageInterfaceNamesForItem (NSUrl itemURL); [Mac (10,13, onlyOn64 : true)] [Export ("protocolForMessageInterface:")] @@ -82,11 +82,11 @@ interface FIFinderSyncProtocol [Mac (10,13, onlyOn64 : true)] [Export ("exportedObjectForMessageInterface:itemURL:error:")] - NSObject GetExportedObject (NSFileProviderMessageInterface messageInterface, NSUrl itemURL, [NullAllowed] out NSError error); + NSObject GetExportedObject (NSFileProviderMessageInterface messageInterface, NSUrl itemUrl, [NullAllowed] out NSError error); [Mac (10,13, onlyOn64 : true)] [Export ("valuesForAttributes:forItemWithURL:completion:")] - void ValuesForAttributes (string[] attributes, NSUrl itemURL, Action, NSError> completion); + void GetValues (string[] attributes, NSUrl itemUrl, Action, NSError> completion); } [Mac (10, 10, onlyOn64: true)] diff --git a/src/medialibrary.cs b/src/medialibrary.cs index 0203ad5ec5d0..1f00309ec41a 100644 --- a/src/medialibrary.cs +++ b/src/medialibrary.cs @@ -158,15 +158,15 @@ interface MediaLibraryTypeIdentifierKey { [Mac (10,13, onlyOn64 : true)] [Field ("MLPhotosLivePhotosGroupTypeIdentifier")] - NSString MLPhotosLivePhotosGroupTypeIdentifier { get; } + NSString PhotosLivePhotosGroupTypeIdentifier { get; } [Mac (10,13, onlyOn64 : true)] [Field ("MLPhotosLongExposureGroupTypeIdentifier")] - NSString MLPhotosLongExposureGroupTypeIdentifier { get; } + NSString PhotosLongExposureGroupTypeIdentifier { get; } [Mac (10,13, onlyOn64 : true)] [Field ("MLPhotosAnimatedGroupTypeIdentifier")] - NSString MLPhotosAnimatedGroupTypeIdentifier { get; } + NSString PhotosAnimatedGroupTypeIdentifier { get; } [Mac (10,10, onlyOn64 : true)] [Field ("MLPhotosPanoramasGroupTypeIdentifier")] From 4a097d71032c6433b64e32cae86249aa72defd50 Mon Sep 17 00:00:00 2001 From: Timothy Risi Date: Wed, 14 Jun 2017 11:02:01 -0800 Subject: [PATCH 07/13] Missed one change to drop 'ForItem' --- src/findersync.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/findersync.cs b/src/findersync.cs index f597f450b93d..67474cff1249 100644 --- a/src/findersync.cs +++ b/src/findersync.cs @@ -74,7 +74,7 @@ interface FIFinderSyncProtocol string ToolbarItemToolTip { get; } [Export ("supportedMessageInterfaceNamesForItemWithURL:")] - string[] GetSupportedMessageInterfaceNamesForItem (NSUrl itemURL); + string[] GetSupportedMessageInterfaceNames (NSUrl itemURL); [Mac (10,13, onlyOn64 : true)] [Export ("protocolForMessageInterface:")] From 7807cedc74e2f9af4bdabf2787420dbea1d07844 Mon Sep 17 00:00:00 2001 From: Timothy Risi Date: Wed, 14 Jun 2017 14:38:26 -0800 Subject: [PATCH 08/13] More PR fixes --- src/findersync.cs | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/findersync.cs b/src/findersync.cs index 67474cff1249..fffd1da273a8 100644 --- a/src/findersync.cs +++ b/src/findersync.cs @@ -5,6 +5,8 @@ #if XAMCORE_2_0 namespace XamCore.FinderSync { + delegate void GetValuesCompletionHandler (NSDictionary values, NSError error); + [Mac (10, 10, onlyOn64: true)] [BaseType (typeof(NSExtensionContext))] interface FIFinderSyncController : NSSecureCoding, NSCopying @@ -34,7 +36,7 @@ interface FIFinderSyncController : NSSecureCoding, NSCopying NSDate GetLastUsedDate (NSUrl itemUrl); [Mac (10,13, onlyOn64 : true)] - [Export ("setLastUsedDate:forItemWithURL:completion:")] + [Async, Export ("setLastUsedDate:forItemWithURL:completion:")] void SetLastUsedDate (NSDate lastUsedDate, NSUrl itemUrl, Action completion); [Mac (10,13, onlyOn64 : true)] @@ -42,7 +44,7 @@ interface FIFinderSyncController : NSSecureCoding, NSCopying [return: NullAllowed] NSData GetTagData (NSUrl itemUrl); - [Mac (10,13, onlyOn64 : true)] + [Async, Mac (10,13, onlyOn64 : true)] [Export ("setTagData:forItemWithURL:completion:")] void SetTagData ([NullAllowed] NSData tagData, NSUrl itemUrl, Action completion); } @@ -74,7 +76,7 @@ interface FIFinderSyncProtocol string ToolbarItemToolTip { get; } [Export ("supportedMessageInterfaceNamesForItemWithURL:")] - string[] GetSupportedMessageInterfaceNames (NSUrl itemURL); + string[] GetSupportedMessageInterfaceNames (NSUrl itemUrl); [Mac (10,13, onlyOn64 : true)] [Export ("protocolForMessageInterface:")] @@ -85,9 +87,9 @@ interface FIFinderSyncProtocol NSObject GetExportedObject (NSFileProviderMessageInterface messageInterface, NSUrl itemUrl, [NullAllowed] out NSError error); [Mac (10,13, onlyOn64 : true)] - [Export ("valuesForAttributes:forItemWithURL:completion:")] - void GetValues (string[] attributes, NSUrl itemUrl, Action, NSError> completion); - } + [Async, Export ("valuesForAttributes:forItemWithURL:completion:")] + void GetValues (string[] attributes, NSUrl itemUrl, GetValuesCompletionHandler completion); + } [Mac (10, 10, onlyOn64: true)] [BaseType (typeof(NSObject))] From 4070db5af186eae4d1027b1f59ee36e0629f0d4d Mon Sep 17 00:00:00 2001 From: Timothy Risi Date: Thu, 15 Jun 2017 10:28:09 -0800 Subject: [PATCH 09/13] Fix test failure --- src/foundation.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/foundation.cs b/src/foundation.cs index 0d06aba83268..c6a7928d654c 100644 --- a/src/foundation.cs +++ b/src/foundation.cs @@ -14229,7 +14229,7 @@ interface NSMeasurementFormatter : NSSecureCoding { [NoWatch, NoTV, Mac (10,13), iOS (11,0)] [BaseType (typeof(NSObject))] - interface NSFileProviderMessageInterface + interface NSFileProviderMessageInterface : NSSecureCoding { [Export ("name")] string Name { get; } From 229316e68fb57c5dddee57d4237017ea3ce51323 Mon Sep 17 00:00:00 2001 From: Timothy Risi Date: Mon, 26 Jun 2017 10:50:49 -0800 Subject: [PATCH 10/13] FinderSync beta 2 --- src/findersync.cs | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/src/findersync.cs b/src/findersync.cs index fffd1da273a8..7789ea92009b 100644 --- a/src/findersync.cs +++ b/src/findersync.cs @@ -75,19 +75,21 @@ interface FIFinderSyncProtocol [Export ("toolbarItemToolTip")] string ToolbarItemToolTip { get; } - [Export ("supportedMessageInterfaceNamesForItemWithURL:")] - string[] GetSupportedMessageInterfaceNames (NSUrl itemUrl); + [Mac (10,13, onlyOn64 : true)] + [Export ("exportedObjectForMessageInterface:itemURL:error:")] + NSObject GetExportedObject (NSFileProviderMessageInterface messageInterface, NSUrl itemUrl, [NullAllowed] out NSError error); [Mac (10,13, onlyOn64 : true)] - [Export ("protocolForMessageInterface:")] - Protocol GetProtocol (NSFileProviderMessageInterface messageInterface); + [Export ("supportedServiceNamesForItemWithURL:")] + string[] SupportedServiceNames (NSUrl itemUrl); [Mac (10,13, onlyOn64 : true)] - [Export ("exportedObjectForMessageInterface:itemURL:error:")] - NSObject GetExportedObject (NSFileProviderMessageInterface messageInterface, NSUrl itemUrl, [NullAllowed] out NSError error); + [Export ("makeListenerEndpointForServiceName:andReturnError:")] + [return: NullAllowed] + NSXPCListenerEndpoint MakeListenerEndpoint (string serviceName, [NullAllowed] out NSError error); [Mac (10,13, onlyOn64 : true)] - [Async, Export ("valuesForAttributes:forItemWithURL:completion:")] + [Export ("valuesForAttributes:forItemWithURL:completion:")] void GetValues (string[] attributes, NSUrl itemUrl, GetValuesCompletionHandler completion); } From 68b87ac253c808e89d850faeb5e5a6c2e012275a Mon Sep 17 00:00:00 2001 From: Timothy Risi Date: Mon, 26 Jun 2017 14:30:20 -0800 Subject: [PATCH 11/13] Add back async tag --- src/findersync.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/findersync.cs b/src/findersync.cs index 7789ea92009b..4959d7892e0e 100644 --- a/src/findersync.cs +++ b/src/findersync.cs @@ -86,10 +86,10 @@ interface FIFinderSyncProtocol [Mac (10,13, onlyOn64 : true)] [Export ("makeListenerEndpointForServiceName:andReturnError:")] [return: NullAllowed] - NSXPCListenerEndpoint MakeListenerEndpoint (string serviceName, [NullAllowed] out NSError error); + NSXpcListenerEndpoint MakeListenerEndpoint (string serviceName, [NullAllowed] out NSError error); [Mac (10,13, onlyOn64 : true)] - [Export ("valuesForAttributes:forItemWithURL:completion:")] + [Async, Export ("valuesForAttributes:forItemWithURL:completion:")] void GetValues (string[] attributes, NSUrl itemUrl, GetValuesCompletionHandler completion); } From 92711a4e46e3d540033ecbaff791a4e3c2beac45 Mon Sep 17 00:00:00 2001 From: Timothy Risi Date: Tue, 27 Jun 2017 09:55:01 -0800 Subject: [PATCH 12/13] FinderSync beta 2 --- src/findersync.cs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/findersync.cs b/src/findersync.cs index 4959d7892e0e..213948082f1b 100644 --- a/src/findersync.cs +++ b/src/findersync.cs @@ -83,11 +83,12 @@ interface FIFinderSyncProtocol [Export ("supportedServiceNamesForItemWithURL:")] string[] SupportedServiceNames (NSUrl itemUrl); +#if FALSE // TODO: Activate after 10.13 foundation APIs have been merged [Mac (10,13, onlyOn64 : true)] [Export ("makeListenerEndpointForServiceName:andReturnError:")] [return: NullAllowed] NSXpcListenerEndpoint MakeListenerEndpoint (string serviceName, [NullAllowed] out NSError error); - +#endif [Mac (10,13, onlyOn64 : true)] [Async, Export ("valuesForAttributes:forItemWithURL:completion:")] void GetValues (string[] attributes, NSUrl itemUrl, GetValuesCompletionHandler completion); From 20cbc006160849f6ab36009b4de1c9f9c09c2b94 Mon Sep 17 00:00:00 2001 From: Timothy Risi Date: Wed, 28 Jun 2017 09:40:18 -0800 Subject: [PATCH 13/13] Add bug# for MakeListenerEndpoint --- src/findersync.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/findersync.cs b/src/findersync.cs index 213948082f1b..3fa06b0fcc78 100644 --- a/src/findersync.cs +++ b/src/findersync.cs @@ -83,7 +83,7 @@ interface FIFinderSyncProtocol [Export ("supportedServiceNamesForItemWithURL:")] string[] SupportedServiceNames (NSUrl itemUrl); -#if FALSE // TODO: Activate after 10.13 foundation APIs have been merged +#if FALSE // TODO: Activate after 10.13 foundation APIs have been merged. Bug 57800 [Mac (10,13, onlyOn64 : true)] [Export ("makeListenerEndpointForServiceName:andReturnError:")] [return: NullAllowed]