Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ObjCRuntime] Add assembly registration event. #1933

Merged
merged 1 commit into from
Mar 29, 2017

Conversation

rolfbjarne
Copy link
Member

Add an assembly registration event, that allows apps to opt out of
Xamarin.Mac's default behavior to recursively load every assembly referenced
by the entry assembly.

This is only for Xamarin.Mac, since it does not make sense to have this API in
Xamarin.iOS because assemblies are statically registered at build time.

Add an assembly registration event, that allows apps to opt out of
Xamarin.Mac's default behavior to recursively load every assembly referenced
by the entry assembly.

This is only for Xamarin.Mac, since it does not make sense to have this API in
Xamarin.iOS because assemblies are statically registered at build time.
@rolfbjarne
Copy link
Member Author

rolfbjarne commented Mar 29, 2017

@slluis Would this approach work for Xamarin Studio?

This is what you'd have to do: https://github.com/xamarin/xamarin-macios/pull/1933/files#diff-cb285180a7660d946e80e2f91effbc1aR10

@rolfbjarne rolfbjarne requested review from spouliot and chamons March 29, 2017 10:28
@slluis
Copy link

slluis commented Mar 29, 2017

Yes, that would work. Thanks!

@rolfbjarne rolfbjarne added this to the d15-2 milestone Mar 29, 2017
@monojenkins
Copy link
Collaborator

Build failure

Copy link
Contributor

@spouliot spouliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make sure this gets documented.

@chamons and also in the release notes

Copy link
Contributor

@chamons chamons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rolfbjarne
Copy link
Member Author

build

@chamons
Copy link
Contributor

chamons commented Mar 29, 2017

Release notes - https://github.com/xamarin/xamarin-macios/wiki/xamarin.mac_3.3#assembly-registration-event

I'll clean up the wording when we get closer, but that should be the gist of it.

@monojenkins
Copy link
Collaborator

Build success

@rolfbjarne rolfbjarne merged commit 3427fb2 into dotnet:master Mar 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants