[Foundation] There's no reason to conditionally exclude code for macOS when the member has a NoMac attribute.

[rolfbjarne]

This ensures that all platform assemblies know that the member doesn't exist
on macOS.

[vs-mobiletools-engineering-service2]

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: e62bdcd7c44f00377069a20e19a3c6e0bdf819ec [PR build]

[vs-mobiletools-engineering-service2]

📚 [PR Build] Artifacts 📚

Packages generated

View packages

• Microsoft.iOS.Bundle.16.2.85-ci.pr.gh17299.pkg
• Microsoft.iOS.Ref.16.2.85-ci.pr.gh17299.nupkg
• Microsoft.iOS.Runtime.ios-arm.16.2.85-ci.pr.gh17299.nupkg
• Microsoft.iOS.Runtime.ios-arm64.16.2.85-ci.pr.gh17299.nupkg
• Microsoft.iOS.Runtime.iossimulator-arm64.16.2.85-ci.pr.gh17299.nupkg
• Microsoft.iOS.Runtime.iossimulator-x64.16.2.85-ci.pr.gh17299.nupkg
• Microsoft.iOS.Runtime.iossimulator-x86.16.2.85-ci.pr.gh17299.nupkg
• Microsoft.iOS.Sdk.16.2.85-ci.pr.gh17299.nupkg
• Microsoft.iOS.Templates.16.2.85-ci.pr.gh17299.nupkg
• Microsoft.iOS.Windows.Sdk.16.2.85-ci.pr.gh17299.nupkg
• Microsoft.MacCatalyst.Bundle.16.2.85-ci.pr.gh17299.pkg
• Microsoft.MacCatalyst.Ref.16.2.85-ci.pr.gh17299.nupkg
• Microsoft.MacCatalyst.Runtime.maccatalyst-arm64.16.2.85-ci.pr.gh17299.nupkg
• Microsoft.MacCatalyst.Runtime.maccatalyst-x64.16.2.85-ci.pr.gh17299.nupkg
• Microsoft.MacCatalyst.Sdk.16.2.85-ci.pr.gh17299.nupkg
• Microsoft.MacCatalyst.Templates.16.2.85-ci.pr.gh17299.nupkg
• Microsoft.macOS.Bundle.13.1.85-ci.pr.gh17299.pkg
• Microsoft.macOS.Ref.13.1.85-ci.pr.gh17299.nupkg
• Microsoft.macOS.Runtime.osx-arm64.13.1.85-ci.pr.gh17299.nupkg
• Microsoft.macOS.Runtime.osx-x64.13.1.85-ci.pr.gh17299.nupkg
• Microsoft.macOS.Sdk.13.1.85-ci.pr.gh17299.nupkg
• Microsoft.macOS.Templates.13.1.85-ci.pr.gh17299.nupkg
• Microsoft.NET.Sdk.iOS.Manifest-7.0.100.16.2.85-ci.pr.gh17299.nupkg
• Microsoft.NET.Sdk.MacCatalyst.Manifest-7.0.100.16.2.85-ci.pr.gh17299.nupkg
• Microsoft.NET.Sdk.macOS.Manifest-7.0.100.13.1.85-ci.pr.gh17299.nupkg
• Microsoft.NET.Sdk.tvOS.Manifest-7.0.100.16.1.873-ci.pr.gh17299.nupkg
• Microsoft.NET.Workload.iOS.16.2.85-ci.pr.gh17299.msi
• Microsoft.tvOS.Bundle.16.1.873-ci.pr.gh17299.pkg
• Microsoft.tvOS.Ref.16.1.873-ci.pr.gh17299.nupkg
• Microsoft.tvOS.Runtime.tvos-arm64.16.1.873-ci.pr.gh17299.nupkg
• Microsoft.tvOS.Runtime.tvossimulator-arm64.16.1.873-ci.pr.gh17299.nupkg
• Microsoft.tvOS.Runtime.tvossimulator-x64.16.1.873-ci.pr.gh17299.nupkg
• Microsoft.tvOS.Sdk.16.1.873-ci.pr.gh17299.nupkg
• Microsoft.tvOS.Templates.16.1.873-ci.pr.gh17299.nupkg
• xamarin.ios-16.2.1.85.pkg
• xamarin.mac-9.1.1.85.pkg

Pipeline on Agent XAMBOT-1173.Monterey'
Hash: e62bdcd7c44f00377069a20e19a3c6e0bdf819ec [PR build]

[dalexsoto]

Did api diff come out clean? Just making sure we did not do this to workaround a generator bug, if so 👍

[vs-mobiletools-engineering-service2]

🔥 [PR Build] Build failed 🔥

Build failed for the job 'Detect API changes'

Pipeline on Agent
Hash: $(GIT_HASH) [PR build]

[vs-mobiletools-engineering-service2]

🔥 Unable to find the contents for the comment: D:\a\1\s\change-detection\results\gh-comment.md does not exist :fire

Pipeline on Agent
Hash: e62bdcd7c44f00377069a20e19a3c6e0bdf819ec [PR build]

[vs-mobiletools-engineering-service2]

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

• iOS (no change detected)
• tvOS (no change detected)
• watchOS (no change detected)
• macOS (no change detected)

NET (empty diffs)

• iOS: (empty diff detected)
• tvOS: (empty diff detected)
• MacCatalyst: (empty diff detected)
• macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

• iOS: vsdrops gist (No breaking changes)
• tvOS: vsdrops gist (No breaking changes)
• watchOS: vsdrops gist (No breaking changes)
• macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

• iOS: vsdrops gist (No breaking changes)
• tvOS: vsdrops gist (No breaking changes)
• MacCatalyst: vsdrops gist (No breaking changes)
• macOS: vsdrops gist (No breaking changes)
• Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

• iOS: vsdrops gist
• tvOS: vsdrops gist
• macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: e62bdcd7c44f00377069a20e19a3c6e0bdf819ec [PR build]

[rolfbjarne]

Did api diff come out clean? Just making sure we did not do this to workaround a generator bug, if so 👍

The API diff is clean.

Interestingly it turns out the generator diff is not, and that's a different bug (#17316) - but this shouldn't have any real effects except for non-linked app size.

[vs-mobiletools-engineering-service2]

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 225 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ framework: All 8 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ generator: All 2 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ linker: All 65 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. [attempt 3] Html Report (VSDrops) Download
✅ monotouch: All 25 tests passed. [attempt 3] Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. [attempt 2] Html Report (VSDrops) Download

Pipeline on Agent
Hash: e62bdcd7c44f00377069a20e19a3c6e0bdf819ec [PR build]