[UIKit] Add Constructor for UIHoverGestureRecognizer #15837

haritha-mohan · 2022-08-31T23:06:10Z

mandel-macaque

Great work, in theory, there are not changes needed if you don't want them. I wonder, if we add at the top of the file:

#nullable enable

What happens? It might as for some changes, maybe to many for the intent of the PR (but good for you to check). Tests for the other actions are missing, but we should write them. We need to add tests under:

tests/monotouch/UIkit

I think we can look at how to test the execution of the callback, and then use a pattern for it.

mandel-macaque · 2022-08-31T23:12:10Z

src/UIKit/UIGestureRecognizer.cs

@@ -319,4 +319,27 @@ public void Activated (UIScreenEdgePanGestureRecognizer sender)
 #endif
 }

+// start code for UIHoverGestureRecognizer Constructor
+	public partial class UIHoverGestureRecognizer : UIGestureRecognizer {
+		public UIHoverGestureRecognizer (Action action) : base (action) {}


I believe this is not needed since we already expose a constructor in the generated code:

[NoWatch, NoTV, iOS (13,0)] [BaseType (typeof (UIGestureRecognizer))] [DisableDefaultCtor] interface UIHoverGestureRecognizer { [DesignatedInitializer] [Export ("initWithTarget:action:")] NativeHandle Constructor (NSObject target, Selector action); [DesignatedInitializer] [Wrap ("base (action)")] NativeHandle Constructor (Action action); }

Have your tried removing it? Is it giving you an issue?

mandel-macaque · 2022-08-31T23:14:44Z

src/UIKit/UIGestureRecognizer.cs

+			public void Activated (UIHoverGestureRecognizer sender)
+			{
+				action (sender);
+			}


Little trick in the new c# syntax, you can do:

Suggested change

public void Activated (UIHoverGestureRecognizer sender)

{

action (sender);

}

public void Activated (UIHoverGestureRecognizer sender) => action (sender);

dalexsoto

This is great 👍

haritha-mohan · 2022-09-01T17:43:50Z

Will be coming back to fix this issue. After talking to Manuel, we realized it would be better to add generics and clean up the code to make the bug much easier to fix.

stephen-hawley · 2022-09-01T20:03:25Z

👀

Fixes dotnet#15335

Added generic callbacks- this simplifies the code and makes it much easier to fix the issue (dotnet#15335).

…o gh15335

rolfbjarne · 2022-09-12T10:13:47Z

.gitignore

+tests/BundledResources/BundledResources.csproj
+tests/EmbeddedResources/EmbeddedResources.csproj
+tests/fsharplibrary/fsharplibrary.fsproj


This change is not related to this PR, so it should be removed.

If needed, it should go in a separate PR, explaining the reason for the change (I'm also a bit puzzled about this change, because these files are already checked into git, so they shouldn't be ignored, nor should this actually change any behavior),

rolfbjarne · 2022-09-12T10:13:55Z

tests/.gitignore

+BundledResources/Info.plist
+EmbeddedResources/Info.plist
+fsharplibrary/Info.plist


This is due to vsmac making changes. I wpuld blame VSMac for modifying files when it should not.

tj-devel709

After addressing the other issues!

rolfbjarne

Looks great!

Except that the compiler complains about the test:

tests/monotouch-test/UIKit/GestureRecognizerTest.cs(98,8): error CS0815: Cannot assign lambda expression to an implicitly-typed variable

vs-mobiletools-engineering-service2 · 2022-09-21T11:13:38Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1105.Monterey'
Hash: c0e19cef9fe40d9adc49c87c8e3a5fa4c6cfcb55 [PR build]

vs-mobiletools-engineering-service2 · 2022-09-21T11:17:48Z

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: c0e19cef9fe40d9adc49c87c8e3a5fa4c6cfcb55 [PR build]

vs-mobiletools-engineering-service2 · 2022-09-21T11:18:33Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
~~tvOS~~ (no change detected)
~~watchOS~~ (no change detected)
~~macOS~~ (no change detected)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
~~tvOS~~: (empty diff detected)
MacCatalyst: vsdrops gist (No breaking changes)
~~macOS~~: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: c0e19cef9fe40d9adc49c87c8e3a5fa4c6cfcb55 [PR build]

vs-mobiletools-engineering-service2 · 2022-09-21T14:09:27Z

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 1 tests failed, 222 tests passed.

Failures

❌ msbuild tests

1 tests failed, 1 tests passed.

MSBuild tests/Integration: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

Successes

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 23 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

rolfbjarne · 2022-09-21T18:40:52Z

Test failure is unrelated (https://github.com/xamarin/maccore/issues/2620), so this is good to go!

mandel-macaque approved these changes Aug 31, 2022

View reviewed changes

dalexsoto reviewed Sep 1, 2022

View reviewed changes

This comment has been minimized.

Sign in to view

haritha-mohan added 2 commits September 2, 2022 12:03

[UIKit] Add Constructor for UIHoverGestureRecognizer

e98163b

Fixes dotnet#15335

Fix Merge Conflict and rebase gh15335

202cd73

Added generic callbacks- this simplifies the code and makes it much easier to fix the issue (dotnet#15335).

haritha-mohan force-pushed the gh15335 branch from 14f0391 to 202cd73 Compare September 6, 2022 21:40

Add files to gitignore

2866ddb

This comment has been minimized.

Sign in to view

Merge branch 'main' into gh15335

8ae4a40

This comment has been minimized.

Sign in to view

haritha-mohan added 2 commits September 8, 2022 09:34

Merge branch 'gh15335' of github.com:haritha-mohan/xamarin-macios int…

0f195a4

…o gh15335

Add tests for Gesture Recognizer

7e45a11

haritha-mohan added the notes-mention Deserves a mention in release notes label Sep 9, 2022

This comment has been minimized.

Sign in to view

rolfbjarne requested changes Sep 12, 2022

View reviewed changes

tj-devel709 approved these changes Sep 12, 2022

View reviewed changes

haritha-mohan added 2 commits September 12, 2022 11:09

Address reviews

f3544ba

Resolve conflict

a59e99b

haritha-mohan requested review from rolfbjarne and mandel-macaque September 12, 2022 18:31

This comment has been minimized.

Sign in to view

rolfbjarne approved these changes Sep 13, 2022

View reviewed changes

Modify lambda expression

abc0e51

haritha-mohan requested a review from rolfbjarne September 20, 2022 20:57

This comment has been minimized.

Sign in to view

Merge branch 'main' into gh15335

c0e19ce

rolfbjarne approved these changes Sep 21, 2022

View reviewed changes

mandel-macaque approved these changes Sep 21, 2022

View reviewed changes

haritha-mohan merged commit a9c8efa into dotnet:main Sep 21, 2022

haritha-mohan deleted the gh15335 branch September 21, 2022 19:54

[UIKit] Add Constructor for UIHoverGestureRecognizer #15837

[UIKit] Add Constructor for UIHoverGestureRecognizer #15837

Conversation

haritha-mohan commented Aug 31, 2022

mandel-macaque left a comment

Choose a reason for hiding this comment

mandel-macaque Aug 31, 2022

Choose a reason for hiding this comment

mandel-macaque Aug 31, 2022

Choose a reason for hiding this comment

dalexsoto left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

haritha-mohan commented Sep 1, 2022

stephen-hawley commented Sep 1, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne Sep 12, 2022

Choose a reason for hiding this comment

rolfbjarne Sep 12, 2022

Choose a reason for hiding this comment

mandel-macaque Sep 12, 2022

Choose a reason for hiding this comment

tj-devel709 left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Sep 21, 2022

📚 [PR Build] Artifacts 📚

Packages generated

vs-mobiletools-engineering-service2 commented Sep 21, 2022

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

vs-mobiletools-engineering-service2 commented Sep 21, 2022

✅ API diff for current PR / commit

✅ API diff vs stable

✅ Generator diff

vs-mobiletools-engineering-service2 commented Sep 21, 2022

🔥 [CI Build] Test results 🔥

Test results

Failures

❌ msbuild tests

Successes

rolfbjarne commented Sep 21, 2022