[PassKit] Update bindings for Xcode 14 beta 1-5 #15613

tj-devel709 · 2022-08-03T07:25:28Z

No description provided.

src/PassKit/PKEnums.cs

src/passkit.cs

…eta123

…4-PassKit-Beta123

stephen-hawley · 2022-08-04T18:29:28Z

This is Apple's error and not ours, but one of the constants uses Cancelled and another used Canceled. While both are accepted, the latter is more appropriate.

tj-devel709 · 2022-08-05T16:39:36Z

This is Apple's error and not ours, but one of the constants uses Cancelled and another used Canceled. While both are accepted, the latter is more appropriate.

Ah very interesting good catch! @stephen-hawley

mandel-macaque · 2022-08-05T17:44:50Z

src/passkit.cs

+		[Internal]
+		[NoWatch, NoTV, iOS (16,0), Mac (13,0), MacCatalyst (16,0)]
+		[Export ("initWithProvisioningCredentialIdentifier:sharingInstanceIdentifier:cardTemplateIdentifier:preview:")]
+		NativeHandle InitWithCardTemplate (string credentialIdentifier, string sharingInstanceIdentifier, string templateIdentifier, PKShareablePassMetadataPreview preview);
+
+		[Internal]
+		[NoWatch, NoTV, iOS (16,0), Mac (13,0), MacCatalyst (16,0)]
+		[Export ("initWithProvisioningCredentialIdentifier:sharingInstanceIdentifier:cardConfigurationIdentifier:preview:")]
+		NativeHandle InitWithCardConfiguration (string credentialIdentifier, string sharingInstanceIdentifier, string templateIdentifier, PKShareablePassMetadataPreview preview);


You have create this two internals but you never use them or expose them to the customers.

🤦 I totally wrote a file for this but I guess I did not include it when creating the PR and do not see it now. Will redo this change and add to PR

vs-mobiletools-engineering-service2 · 2022-08-12T00:29:10Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

~~iOS~~ (no change detected)
~~tvOS~~ (no change detected)
~~watchOS~~ (no change detected)
~~macOS~~ (no change detected)

NET (empty diffs)

~~iOS~~: (empty diff detected)
~~tvOS~~: (empty diff detected)
~~MacCatalyst~~: (empty diff detected)
~~macOS~~: (empty diff detected)

❗ API diff vs stable (Breaking changes)

Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
watchOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
macOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
MacCatalyst: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
macOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 579c6a75e4412fb70ec078d3e1b681dc30a5354e [PR build]

vs-mobiletools-engineering-service2 · 2022-08-12T00:29:50Z

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

✅ All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Hash: 579c6a75e4412fb70ec078d3e1b681dc30a5354e [PR build]

vs-mobiletools-engineering-service2 · 2022-08-12T00:35:57Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1164.Monterey'
Hash: 579c6a75e4412fb70ec078d3e1b681dc30a5354e [PR build]

vs-mobiletools-engineering-service2 · 2022-08-12T00:41:14Z

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

introspection
monotouch-test

Pipeline on Agent
Hash: 579c6a75e4412fb70ec078d3e1b681dc30a5354e [PR build]

vs-mobiletools-engineering-service2 · 2022-08-12T03:40:06Z

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 1 tests failed, 227 tests passed.

Failures

❌ introspection tests

1 tests failed, 12 tests passed.

introspection/watchOS 32-bits - simulator/Debug (watchOS 6.0): Crashed Known issue: HE0038)

Html Report (VSDrops) Download

Successes

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 23 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

rolfbjarne

@tj-devel709 I find a few potential improvements!

rolfbjarne · 2022-08-18T16:47:46Z

src/passkit.cs

+
+		[Static]
+		[Export ("ageThresholdElementWithAge:")]
+		PKIdentityElement AgeThresholdElementWithAge (nint age);


@tj-devel709

This would be better:

PKIdentityElement GetAgeThresholdElement (nint age);

rolfbjarne · 2022-08-18T16:48:12Z

src/passkit.cs

+
+		[Static]
+		[Export ("mayStoreIntentForDays:")]
+		PKIdentityIntentToStore MayStoreIntentForDays (nint days);


PKIdentityIntentToStore GetMayStoreIntent (nint days);

rolfbjarne · 2022-08-18T16:48:59Z

src/passkit.cs

+
+		[Static]
+		[Export ("previewWithPassThumbnail:localizedDescription:")]
+		PKShareablePassMetadataPreview PreviewWithPassThumbnail (CGImage passThumbnail, string description);


PKShareablePassMetadataPreview CreatePreview (CGImage passThumbnail, string description);

rolfbjarne · 2022-08-18T16:49:14Z

src/passkit.cs

+
+		[Static]
+		[Export ("previewWithTemplateIdentifier:")]
+		PKShareablePassMetadataPreview PreviewWithTemplateIdentifier (string templateIdentifier);


PKShareablePassMetadataPreview CreatePreview (string templateIdentifier);

TJ Lambert added 2 commits August 1, 2022 17:01

Starting Xcode14 changes for PassKit Beta 123

6bb7077

use protocol correctly, ignore conformance

f676097

tj-devel709 added the notes-mention Deserves a mention in release notes label Aug 3, 2022

tj-devel709 added this to the xcode14 milestone Aug 3, 2022

dalexsoto requested changes Aug 3, 2022

View reviewed changes

mandel-macaque requested changes Aug 3, 2022

View reviewed changes

src/passkit.cs Show resolved Hide resolved

src/passkit.cs Show resolved Hide resolved

src/passkit.cs Show resolved Hide resolved

src/passkit.cs Show resolved Hide resolved

src/passkit.cs Show resolved Hide resolved

TJ Lambert added 3 commits August 3, 2022 11:16

make suggested changes

fe95812

Merge remote-tracking branch 'xamarin/xcode14' into Xcode14-PassKit-B…

01b40e7

…eta123

add the abstract to the ignore files

85ca3f5