[dotnet] Add support for selecting whether to create P/Invoke wrappers or not. Fixes #4940. #14961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s or not. Fixes dotnet#4940. * This is a potential mitigation for slower transition to native code when exception marshalling is enabled (dotnet#14812). * A minor modification was required in the linker, to make sure any modified assemblies are saved. Fixes dotnet#4940.
mauroa
approved these changes
May 9, 2022
| if (modified) { | ||
| var action = Context.Annotations.GetAction (assembly); | ||
| switch (action) { | ||
| case AssemblyAction.Copy: |
There was a problem hiding this comment.
Are you expecting more cases anytime soon or why choosing a switch for just one case?
You could avoid the nested if with if (modified && Context.Annotations.GetAction (assembly) == AssemblyAction.Copy) { ... }
There was a problem hiding this comment.
I simplified this a bit
chamons
approved these changes
May 9, 2022
dalexsoto
approved these changes
May 9, 2022
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
📚 [CI Build] Artifacts 📚Artifacts were not provided. Pipeline on Agent XAMBOT-1044.Monterey |
💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻✅ All tests on macOS Mac Catalina (10.15) passed. Pipeline on Agent |
📋 [PR Build] API Diff 📋API Current PR diff✅ API Diff (from PR only) (no change) View dotnet API diffView dotnet legacy API diffAPI diff✅ API Diff from stable View dotnet API diffView dotnet legacy API diffGenerator diff✅ Generator Diff (no change) Pipeline on Agent XAMBOT-1023.Monterey' |
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌Failed tests are:
Pipeline on Agent |
❌ [CI Build] Tests failed on VSTS: simulator tests iOS ❌Tests failed on VSTS: simulator tests iOS. Test results17 tests failed, 132 tests passed.Failed tests
Pipeline on Agent XAMBOT-1044.Monterey |
|
Test failures are unrelated (#14943). |
rolfbjarne
added a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
May 11, 2022
…s or not. Fixes dotnet#4940. (dotnet#14961) * This is a potential mitigation for slower transition to native code when exception marshalling is enabled (dotnet#14812). * A minor modification was required in the linker, to make sure any modified assemblies are saved. Fixes dotnet#4940.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exception marshalling is enabled ([net6]
xamarin_get_frame_lengthperformance regression #14812).assemblies are saved.
Fixes #4940.