[AVFoundation] Simplify code behind + api definition for AVCaptureConnection. #14199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove the code behind for AVCaptureConnection.SupportsVideoMinFrameDuration and AVCaptureConnection.SupportsVideoMaxFrameDuration. The codebehind looks like a workaround for Apple renaming the selector, but from history it looks like that happened before the earliest version of iOS we support today, so this can be expressed in an api definition now without any code behind. * Add these fields to macOS, where they're not even deprecated (like they are on other platforms). * Remove conditional code in api definition, and distribute [No*] attributes as required. * Remove the AVCaptureConnection.AudioChannels property from .NET, it doesn't do anything useful.
rolfbjarne
requested review from
mandel-macaque and
dalexsoto
as code owners
rolfbjarne
added
not-notes-worthy
mandel-macaque
approved these changes
Feb 18, 2022
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View dotnet API diffView dotnet legacy API diffView dotnet iOS-MacCatalayst API diff
API Current PR diffView dotnet API diffView dotnet legacy API diffView dotnet iOS-MacCatalayst API diff
GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results9 tests failed, 139 tests passed.Failed tests
Pipeline on Agent XAMBOT-1107.Monterey' |
✅ [PR Build] Tests passed on Build. ✅Tests passed on Build. API diff✅ API Diff from stable View dotnet API diffView dotnet legacy API diffAPI Current PR diffℹ️ API Diff (from PR only) (please review changes) View dotnet API diffView dotnet legacy API diffGenerator diffℹ️ Generator Diff (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): 🎉 All 148 tests passed 🎉Pipeline on Agent XAMBOT-1100.BigSur' |
tj-devel709
pushed a commit
to tj-devel709/xamarin-macios
that referenced
this pull request
Mar 8, 2022
…nection. (dotnet#14199) * Remove the code behind for AVCaptureConnection.SupportsVideoMinFrameDuration and AVCaptureConnection.SupportsVideoMaxFrameDuration. The codebehind looks like a workaround for Apple renaming the selector, but from history it looks like that happened before the earliest version of iOS we support today, so this can be expressed in an api definition now without any code behind. * Add these fields to macOS, where they're not even deprecated (like they are on other platforms). * Remove conditional code in api definition, and distribute [No*] attributes as required. * Remove the AVCaptureConnection.AudioChannels property from .NET, it doesn't do anything useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and AVCaptureConnection.SupportsVideoMaxFrameDuration. The codebehind looks like
a workaround for Apple renaming the selector, but from history it looks like that
happened before the earliest version of iOS we support today, so this can be expressed
in an api definition now without any code behind.
other platforms).
required.
anything useful.