[msbuild/dotnet] Make codesigning createdump work in universal apps. Fixes #14155. #14196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ixes dotnet#14155. We don't sign each rid-specific bundle, but we sign the final merged app bundle instead. This means that we must store the list of files to codesign from the rid-specific build and load those lists before running codesign on the merged app bundle. dotnet#14155.
rolfbjarne
added
not-notes-worthy
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View dotnet API diffView dotnet legacy API diffView dotnet iOS-MacCatalayst API diff
API Current PR diffView dotnet API diffView dotnet legacy API diffView dotnet iOS-MacCatalayst API diff
GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results2 tests failed, 144 tests passed.Failed tests
Pipeline on Agent XAMBOT-1097.BigSur' |
|
Test failures are unrelated:
|
tj-devel709
pushed a commit
to tj-devel709/xamarin-macios
that referenced
this pull request
Mar 8, 2022
…ixes dotnet#14155. (dotnet#14196) We don't sign each rid-specific bundle, but we sign the final merged app bundle instead. This means that we must store the list of files to codesign from the rid-specific build and load those lists before running codesign on the merged app bundle. dotnet#14155.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't sign each rid-specific bundle, but we sign the final merged app bundle instead.
This means that we must store the list of files to codesign from the rid-specific
build and load those lists before running codesign on the merged app bundle.
Fixes #14155.