[MapKit] Update bindings for Xcode 13.0 beta 1 and beta 2 #12081
Conversation
rachelkang
added
the
note-highlight
|
|
||
| !missing-field! MKAnnotationCalloutInfoDidChangeNotification not bound | ||
| !missing-protocol-conformance! MKUserLocation should conform to MKAnnotation | ||
| !missing-protocol-member! MKOverlay::coordinate not found |
There was a problem hiding this comment.
copied iOS-MapKit.ignore file contents - all are relevant to MacCatalyst as well (wrt .todo file and xtro)
|
|
||
| !missing-field! MKAnnotationCalloutInfoDidChangeNotification not bound | ||
| !missing-protocol-conformance! MKUserLocation should conform to MKAnnotation | ||
| !missing-protocol-member! MKOverlay::coordinate not found |
There was a problem hiding this comment.
Why is this one ignored? !missing-protocol-member! MKOverlay::coordinate not found
There was a problem hiding this comment.
I'm not sure, but I just copied the contents of the ios ignore file (It fails on xtro otherwise)
| @@ -769,12 +769,15 @@ interface MKMapViewDelegate { | |||
| [Export ("mapViewDidChangeVisibleRegion:")] | |||
| void DidChangeVisibleRegion (MKMapView mapView); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Small, but i would revert changes like this to keep the blame more neat
There was a problem hiding this comment.
thanks TJ! I'm not sure how to do this now, but will be sure to look out for these in the future
There was a problem hiding this comment.
Will land it because I don't want to wait for a build, but you can do something like this:
git diff -U0 -w --no-color | git apply --cached --ignore-whitespace --unidiff-zero -
✅ [PR Build] Tests passed on Build. ✅Tests passed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): 🎉 All 86 tests passed 🎉Pipeline on Agent XAMBOT-1104.BigSur' |
✅ [PR Build] Tests passed on Build. ✅Tests passed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): 🎉 All 86 tests passed 🎉Pipeline on Agent XAMBOT-1101.BigSur' |
| @@ -769,12 +769,15 @@ interface MKMapViewDelegate { | |||
| [Export ("mapViewDidChangeVisibleRegion:")] | |||
| void DidChangeVisibleRegion (MKMapView mapView); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Will land it because I don't want to wait for a build, but you can do something like this:
git diff -U0 -w --no-color | git apply --cached --ignore-whitespace --unidiff-zero -
Catalyst-related edits were necessary to make xtro happy