Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AVPlayerItemMetadataCollector and SKCloudServiceController have DisableDefaultCtor incorrectly #8398

Closed
chamons opened this issue Apr 15, 2020 · 0 comments
Closed

AVPlayerItemMetadataCollector and SKCloudServiceController have DisableDefaultCtor incorrectly #8398

chamons opened this issue Apr 15, 2020 · 0 comments
Assignees
@chamons
Labels
bug If an issue is a bug or a pull request a bug fix
Milestone
Future

Comments

@chamons
Copy link
Contributor

chamons commented Apr 15, 2020

During this PR, it was noticed that some of our bindings were incorrectly fixed in maccore/e729f9ca90a95b1fa9cfe9b418ff0d949912107e

#8370 (review)
@chamons chamons added the bug If an issue is a bug or a pull request a bug fix label Apr 15, 2020
@chamons chamons added this to the Future milestone Apr 15, 2020
@chamons chamons self-assigned this Apr 15, 2020
@chamons chamons mentioned this issue Apr 15, 2020
Merged
chamons added a commit to chamons/xamarin-macios that referenced this issue Apr 15, 2020
@chamons
Add missing ctors to AVPlayerItemMetadataCollector and SKCloudService…
4539f66 
…Controller

- dotnet#8398
- They were incorrectly marked DisableDefaultCtor in an attempt to fix API breaks
- Manual tests/documentation shows that the default init works
@chamons chamons mentioned this issue Apr 15, 2020
Merged
chamons added a commit that referenced this issue Apr 17, 2020
@chamons
Add missing ctors to AVPlayerItemMetadataCollector and SKCloudService…
e2a7361 
…Controller (#8403)

- #8398
- They were incorrectly marked DisableDefaultCtor in an attempt to fix API breaks
- Manual tests/documentation shows that the default init works
@chamons chamons closed this as completed Apr 17, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Apr 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chamons chamons

Labels
bug If an issue is a bug or a pull request a bug fix
Projects
None yet
Milestone
Future
Development

No branches or pull requests
1 participant
@chamons