Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NativeAOT: investigate whether we want to pull in linker features from ILC build logic and pass to ILLinker #18480

Closed
Tracked by #17339
rolfbjarne opened this issue Jun 21, 2023 · 1 comment
Closed
Tracked by #17339

NativeAOT: investigate whether we want to pull in linker features from ILC build logic and pass to ILLinker #18480

rolfbjarne opened this issue Jun 21, 2023 · 1 comment
Labels
enhancement The issue or pull request is an enhancement
Milestone
.NET 8

Comments

@rolfbjarne
Copy link
Member

Ref: #17374 (comment)

We might want to pass the following options to ILLinker:

https://github.com/dotnet/runtime/blob/0b263953a25136283d3ac45a174b82e49a562aa1/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets#L271-L273
@rolfbjarne rolfbjarne added the enhancement The issue or pull request is an enhancement label Jun 21, 2023
@rolfbjarne rolfbjarne added this to the .NET 8 milestone Jun 21, 2023
This was referenced Jun 21, 2023
Merged
Closed
@ivanpovazan
Copy link
Contributor

This has been fixed on dotnet/runtime side via:

The remaining CanEmitObjectArrayDelegate private feature switch is automatically passed to ILLink, as it is now being added to RuntimeHostConfigurationOption by importing NativeAOT build integration targets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue or pull request is an enhancement
Projects
None yet
Milestone
.NET 8
Development

No branches or pull requests
2 participants
@rolfbjarne @ivanpovazan