Skip to content

Commit

Permalink
[DeviceCheck] Add support for Xcode 14 beta 4. (#15639)
Browse files Browse the repository at this point in the history
  • Loading branch information
@mandel-macaque
mandel-macaque authored Aug 5, 2022
1 parent 448f3e5 commit 7749b91
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 21 deletions.
8 changes: 4 additions & 4 deletions src/devicecheck.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

namespace DeviceCheck {

[TV (11,0), NoWatch, iOS (11,0)]
[TV (11,0), Watch (9,0), iOS (11,0)]
[Mac (10,15)]
[ErrorDomain ("DCErrorDomain")]
[Native]
Expand All @@ -26,11 +26,11 @@ public enum DCError : long {
ServerUnavailable,
}

[TV (11,0), NoWatch, iOS (11,0)]
[TV (11,0), Watch (9,0), iOS (11,0)]
[Mac (10,15)]
delegate void DCDeviceGenerateTokenCompletionHandler ([NullAllowed] NSData token, [NullAllowed] NSError error);

[TV (11,0), NoWatch, iOS (11,0)]
[TV (11,0), Watch (9,0), iOS (11,0)]
[Mac (10,15)]
[DisableDefaultCtor] // From the documentation it seems the only way to create a usable instance is to use the static CurrentDevice property.
[BaseType (typeof (NSObject))]
Expand All @@ -48,7 +48,7 @@ interface DCDevice {
void GenerateToken (DCDeviceGenerateTokenCompletionHandler completion);
}

[NoWatch]
[Watch (9,0)]
[iOS (14,0)]
[Mac (11,3)]
[TV (15,0)]
Expand Down
5 changes: 1 addition & 4 deletions src/frameworks.sources
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1967,6 +1967,7 @@ COMMON_FRAMEWORKS = \
CoreML \
CoreVideo \
Compression \
DeviceCheck \
Foundation \
GameKit \
NaturalLanguage \
Expand Down Expand Up @@ -2009,7 +2010,6 @@ MACOS_FRAMEWORKS = \
CoreSpotlight \
CoreText \
CoreWlan \
DeviceCheck \
EventKit \
ExecutionPolicy \
ExternalAccessory \
Expand Down Expand Up @@ -2118,7 +2118,6 @@ IOS_FRAMEWORKS = \
CoreSpotlight \
CoreTelephony \
CoreText \
DeviceCheck \
EventKit \
EventKitUI \
ExternalAccessory \
Expand Down Expand Up @@ -2237,7 +2236,6 @@ TVOS_FRAMEWORKS = \
CoreLocation \
CoreSpotlight \
CoreText \
DeviceCheck \
ExternalAccessory \
GLKit \
GameController \
Expand Down Expand Up @@ -2310,7 +2308,6 @@ MACCATALYST_FRAMEWORKS = \
CoreTelephony \
CoreText \
CoreWlan \
DeviceCheck \
EventKit \
EventKitUI \
ExternalAccessory \
Expand Down
2 changes: 1 addition & 1 deletion tests/introspection/ApiTypeTest.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public class ApiTypeTest : ApiBaseTest {
bool Skip (Type type)
{
switch (type.Namespace) {
#if __IOS__
#if __IOS__ || __WATCHOS__
// running the .cctor on the simulator works... but makes some other CoreNFC intro tests fail later
// we'll still get the results from device tests
case "CoreNFC":
Expand Down
12 changes: 0 additions & 12 deletions tests/xtro-sharpie/watchOS-DeviceCheck.todo
View file

This file was deleted.

1 change: 1 addition & 0 deletions tools/common/Frameworks.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -519,6 +519,7 @@ public static Frameworks GetwatchOSFrameworks (bool is_simulator_build)
{ "OSLog", "OSLog", 8,0 },
{ "ShazamKit", "ShazamKit", new Version (8, 0), NotAvailableInSimulator},

{ "DeviceCheck", "DeviceCheck", 9,0 },
{ "CallKit", "CallKit", 9,0 },
};
}
Expand Down

5 comments on commit 7749b91

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💻 [CI Build] Tests on macOS Mac Catalina (10.15) passed 💻

✅ All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Hash: 7749b91153e0ce7c08d64bd58f76f13fd8f3a898 [CI build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS: vsdrops gist (No breaking changes)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

❗ API diff vs stable (Breaking changes)

Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
  • iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
  • tvOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
  • watchOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
  • macOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
  • iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
  • tvOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
  • MacCatalyst: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
  • macOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
  • Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist
Legacy Xamarin (stable) vs .NET

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 7749b91153e0ce7c08d64bd58f76f13fd8f3a898 [CI build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ [CI Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

  • introspection
  • xammac_tests
  • monotouch-test

Pipeline on Agent
Hash: 7749b91153e0ce7c08d64bd58f76f13fd8f3a898 [CI build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📚 [CI Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMMINI-060.Monterey
Hash: 7749b91153e0ce7c08d64bd58f76f13fd8f3a898 [CI build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 3 tests failed, 225 tests passed.

Failures

❌ introspection tests

1 tests failed, 12 tests passed.
  • introspection/watchOS 32-bits - simulator/Debug (watchOS 6.0): Crashed Known issue: HE0038)

Html Report (VSDrops) Download

❌ xtro tests

2 tests failed, 0 tests passed.
  • Xtro/Legacy Xamarin: Failed (Test run failed.)
  • Xtro/.NET: BuildFailure

Html Report (VSDrops) Download

Successes

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 23 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [CI build]

Please sign in to comment.