Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Enhancement] Ability to set BackgroundColor for ViewCell #2909

Closed
pfedotovsky opened this issue Jun 2, 2018 · 5 comments
Closed

[Enhancement] Ability to set BackgroundColor for ViewCell #2909

pfedotovsky opened this issue Jun 2, 2018 · 5 comments
Labels
in-progress This issue has an associated pull request that may resolve it! proposal-open t/enhancement ➕

Comments

@pfedotovsky
Copy link

It would be nice to have BackgroundColor property on ViewCell.

E.g. when using TableView, section headers and items both have the same background color on Android, making them difficult to distinguish.

There's open source project xfgloss that adds missing properties, but it currently has an issue with Android: tbaggett/xfgloss#29

It would be nice to have this functionality out of the box.

@seanyda
Copy link
Contributor

seanyda commented Jun 4, 2018

Do you mean to add a BackgroundColor property to TextCell, SwitchCell etc? You would just add the BackgroundColor to the View assigned on the ViewCell.

@pfedotovsky
Copy link
Author

@seanyda yes, I mean adding BackgroundColor to TextCell, SwitchCell, etc. I thought that adding the property to ViewCell automatically adds it to all kind of cells, but now I realized that TextCell doesn't inherit from ViewCell. So probably the right class to extend with BackgroundColor is Cell.

Supporting all kinds of cells would be nice, but if it's difficult to do for all cells at once, TextCell would be an excellent place to start.

@seanyda
Copy link
Contributor

seanyda commented Jun 5, 2018

There is a method you can override (which I assume is what XFGloss uses) called SetBackgroundColor which comes from the CellRenderer class. It would be nice to have it as a property in forms though.

@samhouts samhouts added inactive Issue is older than 6 months and needs to be retested help wanted We welcome community contributions to any issue, but these might be a good place to start! up-for-grabs We welcome community contributions to any issue, but these might be a good place to start! labels Jul 4, 2019
@samhouts samhouts added in-progress This issue has an associated pull request that may resolve it! inactive Issue is older than 6 months and needs to be retested and removed inactive Issue is older than 6 months and needs to be retested labels Oct 2, 2019
@jsclay
Copy link

jsclay commented Dec 12, 2019

Any update on this issue? Thanks!

@samhouts samhouts added proposal-open and removed inactive Issue is older than 6 months and needs to be retested labels Feb 6, 2020
@samhouts samhouts removed help wanted We welcome community contributions to any issue, but these might be a good place to start! up-for-grabs We welcome community contributions to any issue, but these might be a good place to start! labels Feb 7, 2020
@jfversluis
Copy link
Member

Hey look at that! I made a PR for this one, looooong time ago! ANyway, this won't be happening for Forms anymore :)

Thanks for all your time and effort on this everyone!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
in-progress This issue has an associated pull request that may resolve it! proposal-open t/enhancement ➕
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants