Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility issues #751

Closed
plweil opened this issue Aug 24, 2020 · 1 comment
Closed

Accessibility issues #751

plweil opened this issue Aug 24, 2020 · 1 comment

Comments

@plweil
Copy link
Contributor

plweil commented Aug 24, 2020

Issue Type (delete the irrelevant ones)

Enhancement Request

Specs

version 2.21.0

What browser?
Chrome 84.0.4147.135

Expected Behavior

Tables should meet WCAG accessibility guidelines. Search should have an accessible name; e.g., a label; column headers/sort "buttons" should be keyboard accessible; elements should have sufficient color contrast

Actual Behavior

Sort is not accessible for keyboard/screen reader users; Search is missing a label; several elements fail WCAG color contrast requirements.

Steps to Reproduce the Problem

Run vue-good-table through Axe, ARC Toolkit and similar accessibility testing tools. Or try using a screenreader, such as VoiceOver, to sort tables.

[EDIT]
I've submitted PR #752 to resolve (some of) these issues.

@xaksis
Copy link
Owner

xaksis commented Feb 28, 2021

PR has been merged. Thank you @plweil

@xaksis xaksis closed this as completed Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants