Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Code] Remove <br> fix #2

Closed
justintadlock opened this issue Feb 10, 2024 · 1 comment
Closed

[Code] Remove <br> fix #2

justintadlock opened this issue Feb 10, 2024 · 1 comment
Assignees
@justintadlock
Labels
🧪 Enhancement Spinning up new features in the lab. WordPress Issue Whatcha doin' to me WordPress/Gutenberg?

Comments

@justintadlock
Copy link
Contributor

Gutenberg is adding extra <br> characters in. We can remove the replacement of those in src/Tools/CodeBlockHighlight.php when this ticket is fixed:
@justintadlock justintadlock added 🧪 Enhancement Spinning up new features in the lab. WordPress Issue Whatcha doin' to me WordPress/Gutenberg? labels Feb 10, 2024
@justintadlock justintadlock self-assigned this Feb 10, 2024
@justintadlock justintadlock changed the title Remove Code block <br> fix [Code] Remove <br> fix Feb 10, 2024
@justintadlock
Copy link
Contributor Author

After investigation, it seems that is an issue with the Prism.js library in use not respecting valid HTML.

More info here: WordPress/gutenberg#59548 (comment)

For this reason, I'm closing this because the fix is on our end and not Core. The existing fix needs to remain to ensure Prism is properly handling markup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justintadlock justintadlock

Labels
🧪 Enhancement Spinning up new features in the lab. WordPress Issue Whatcha doin' to me WordPress/Gutenberg?
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@justintadlock