Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

click_govuk_button should work with <input type="submit"> #21

Closed
frankieroberto opened this issue Sep 15, 2023 · 0 comments · Fixed by #24
Closed

click_govuk_button should work with <input type="submit"> #21

frankieroberto opened this issue Sep 15, 2023 · 0 comments · Fixed by #24
Labels
bug Something isn't working

Comments

@frankieroberto
Copy link
Contributor

The click_govuk_button helper should also work with <input type="submit">, mirroring the behaviour of click_button.
@frankieroberto frankieroberto added the bug Something isn't working label Sep 15, 2023
frankieroberto added a commit that referenced this issue Sep 17, 2023
@frankieroberto
Add support for input type=submit
a0b822a 
Whilst the `<button>` element is the preferred way to create buttons nowadays, `<input type="submit">` is still supported, including by `govuk-frontend`.

For this reason, we should continue to support it with the helper, to avoid throwing unnecessary errors.

Fixes #21
@frankieroberto frankieroberto mentioned this issue Sep 17, 2023
Merged
frankieroberto added a commit that referenced this issue Sep 18, 2023
@frankieroberto
Add support for input type=submit (#24)
c02d6d6 
Whilst the `<button>` element is the preferred way to create buttons
nowadays, `<input type="submit">` is still supported, including by
`govuk-frontend`.

For this reason, we should continue to support it with the helper, to
avoid throwing unnecessary errors.

Fixes #21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for input type=submit x-govuk/govuk-rspec-helpers
1 participant
@frankieroberto