Remove horizontal padding within primary nav #157
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the horizontal padding within the items in the primary navigation.
Whilst the horizontal padding does increase the target area, it also leads to the border-bottom on the first item extending into the margin of the page, which arguably looks a bit odd.
The draft One Login service header does not add horizontal padding, and neither does many of the service using this pattern (for example, Apply for teacher training) or the version of the pattern in the MOJ design system.
However the primary navigation bar on the Design System website itself does add horizontal padding.
An in-between option might be to have the padding for the increased target area, but to keep the border on the bottom of the active item to the width of the text.
However, given the height of the navigation bar, and the likely width of each item (which depends on the text), I think the target area size could already be considered sufficient?
Screenshots
Before
After