Local verification #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement local verification by accessing the certificates from their public URLs, and verify them using jsonwebtoken crate. - Use Cache-Control response header to determine when to re-download the certificates. - Parameterize the IdInfo struct - in the decoded token, the fields are not strings like in the debug API, but their real types. - Modify the interface to distinguish between the slow and unrecommended debug API and the API for local verification - Add a small test to see that the cached certificates work.
|
Awesome! Thanks for the hard work. Will merge, test and publish. |
|
Is available to download on crates.io yet? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a whole bunch of changes, ultimately addressing issue #2.