Change default node-version-file to package.json #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
force-pushed
the
change-default-node-version-file-to-package.json
branch
from
25d0de3
to
03523cc
Compare
NullVoxPopuli
deleted the
change-default-node-version-file-to-package.json
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the wake of nodejs/node#49911
I noticed that
actions/setup-nodedoesn't inherently support volta by default. It requires thatnode-version-fileis set, which this PR changes to be the package.json, since the stated goal of this action is to easily support volta and package.json configs out of the box without configuration.Tested here: https://github.com/NullVoxPopuli/actions-testing/actions/workflows/testing.yml
(and compared with various other environment scenarios)
Ran in to this: actions/setup-node#864
which this repo suffers from