Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eslint fixes #1294

Merged
merged 8 commits into from
Jan 6, 2017
Merged

Eslint fixes #1294

merged 8 commits into from
Jan 6, 2017

Conversation

nknapp
Copy link
Collaborator

@nknapp nknapp commented Jan 6, 2017

This is the PR #1269 without changing the TravisCI-Configuration

Rule 'no-empty-label' was removed and replaced by: ‘no-labels’.
‘no-labels’ already in the project
Rule 'space-after-keywords' was removed and replaced by:
‘keyword-spacing’.
Rule 'space-return-throw-case' was removed and replaced by:
‘keyword-spacing’. ‘keyword-spacing’ already existed
‘depthString' is assigned a value but never used
@nknapp nknapp merged commit d117b3e into handlebars-lang:master Jan 6, 2017
@nknapp nknapp mentioned this pull request Jan 6, 2017
nknapp added a commit that referenced this pull request Mar 9, 2017
Original PR by @travnels, commit-message edited by @nknapp

* Upgraded eslint to 19.0.0
* Cleaned up duplicate rules 'no-extra-parens', 'quote-props'
* eslint rule 'no-empty-label' was replaced.
  Rule 'no-empty-label' was removed and replaced by: ‘no-labels’. ‘no-labels’ already in the project
* eslint rule 'space-after-keywords' has been replaced
  Rules 'space-after-keywords' and 'space-return-throw-case' wer removed and replaced by ‘keyword-spacing’.
* Added parsoer-option: sourceType='module'
* Add unnecessary=false to 'quote-props' to remove warnings about unnecessarily quoted property. 

Code corrections
* helpers.js: unused variable 'depthString' removed, detected by new eslint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants