Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird behavior when tapping on the toolbar #101

Closed
cibeleasreis opened this issue Nov 12, 2020 · 8 comments
Closed

Weird behavior when tapping on the toolbar #101

cibeleasreis opened this issue Nov 12, 2020 · 8 comments

Comments

@cibeleasreis
Copy link

I'm facing some issues when selecting/deselecting actions from the toolbar. They don't get enabled/disabled consistently.
I found this issue at this example too:
https://wxik.github.io/react-native-rich-editor/web/

please see the video below:
https://vimeo.com/478617581

@cibeleasreis
Copy link
Author

The SELECTION_CHANGE is not returning the right actions that should be selected. The handler seems broken at editor.js

@SalehAly01
Copy link

@cibeleasreis I am facing the same issue as well.
When I try to use italic, it might enable bold with it and when trying to deselect bold, it might deselect both bold and italic.

@cibeleasreis
Copy link
Author

Hey @SalehAly01
I found the issue and had a temporary solution for that.

I just commented the focus function on the editor. Here's my change:
4785ab8

@dheysonalves
Copy link

dheysonalves commented Nov 27, 2020

I got some related issue when selecting and deselecting a custom icon from the toolbar.

@SalehAly01
Copy link

Thank you @cibeleasreis
I did that and it fixed the issue.

@cristianoccazinsp
Copy link

Still broken for me with 1.5.4

@stulip
Copy link
Member

stulip commented Dec 24, 2020

Fixed in 1.5.5

@stulip stulip closed this as completed Dec 24, 2020
@cristianoccazinsp
Copy link

Not entirely fixed: #127 with video and example code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants