Require the non-minified dist build in index #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`index.js` was introduced in 5023619, and it imports the minified distribution build by default. This causes two problems: 1. It necessitates the addition of special workarounds to get the unminified build in development. 2. It causes webpack to break if users have the `noParse` option set for minified libraries, say with a pattern that matches `*.min.js.`. This option greatly enhances performance for webpack builds as it doesn't unpack and repack minified libraries, but it has a hard constraint that the unprocessed file **NOT** use `require()`. Requiring the unminified build by default lets downstream tools handle bundling and minification in production, instead of forcing it by default.
wwayne
added a commit
that referenced
this pull request
Feb 15, 2016
Require the non-minified dist build in index
|
Thanks for your information : ) |
|
🍰 ✨ thank you! Are you planning an NPM release sometime soon? |
|
Just released 1.1.2 |
|
😍 You === best. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
index.jswas introduced in 5023619, and it imports the minified distribution build by default. This causes two problems:noParseoption set for minified libraries, say with a pattern that matches*.min.js.. This option greatly enhances performance for webpack builds as it doesn't unpack and repack minified libraries, but it has a hard constraint that the unprocessed file NOT userequire().Requiring the unminified build by default lets downstream tools handle bundling and minification in production, instead of forcing it by default.