better fix for Maximum call stack size exceeded #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 9, 2016
| return y + _offsetEffectY + yPosition | ||
| } | ||
|
|
||
| var windoWidth = window.innerWidth |
There was a problem hiding this comment.
@enjalot Little typo :)
Edit: Ouh it was there before, so maybe it was intentional ;P
There was a problem hiding this comment.
hah i didn't notice. nice way to save a character ;)
wwayne
added a commit
that referenced
this pull request
Jan 10, 2016
better fix for Maximum call stack size exceeded
|
Thanks 👍 |
|
@enjalot NPM published, v1.0.0 |
|
awesome! 💯 thanks so much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've implemented a more thorough handling for tooltips going outside of the window. The problem occurs in both float or solid mode when updating the place of the tooltip will also put it outside the window, this can happen with items (like icons) placed in a corner of the screen.
This code will only update the place of the tooltip if updating it will not put the tooltip outside in anyway. In most cases this should still fix the positioning, but for the rare cases that it doesnt it will simply allow the tooltip to go outside of the window rather than erroring with Maximum call stack size exceeded.
I've re-enabled the functionality for solid since this should always work.