Add support for borders #55
Conversation
Fixes a typo in the active class in the example caused the `Light`-button to never stay in the `active` state even though the tooltip was changed.
This adds the ability to add a one pixel border of the same color as the
text by adding the `border` attribute to the JSX component, like this
`<ReactTooltip border />` or `<ReactTooltip border={true} />`.
This also adds the new feature to the example page and tweaks heights
accordingly.
|
I used to think users can just use the feature But I'd like to support in the way of Anyway, thanks 👍 |
|
My original thought was to do it like that as well, but I thought I'd create a basic version first, especially since you don't seem to support custom colors in any way other than custom class. Borders around speech bubbles (specifically with the little arrow) are quite complicated, so I don't think you could support anything other than Let me know if you want me to keep working on this or if you want to take it from here? :) |
|
Just checked, yes it's also difficult to set the border-with on the little arrow. |
|
To me, it would make more sense to just go with these changes now for a minor release and then go for a major one where styling of the entire component is doable without custom CSS and |
|
I prefer setting the border color, then I can release after polishing some details. |
|
Okay, go ahead. |
|
Nice! :) Would you mind publishing the new version to NPM? |
|
Just published in npm, there is a bug just being found, so I wanted to fix it before publishing. |
|
Ah, I see. Thanks :) |
This adds the ability to add a one pixel border of the same color as the text by adding the
borderattribute to the JSX component, like this<ReactTooltip border />or<ReactTooltip border={true} />.This also adds the new feature to the example page and tweaks heights accordingly.
Also, I threw a small typo fix in there.