fix(index.js): Use correct orientation when mouse enters #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getPosition has to be called before first setting the state (and thus rendering the tooltip) when mouse enters, to take into account cases when the position is close to the client window edge ReactTooltip#388
|
This seems reasonable to me, I just need to check it out. Do you notice any different behavior on the examples? |
|
Didn't find any problem |
|
Sorry @an4ger , I merged another PR that causes conflicts. Can you resolve them? |
# Conflicts: # src/index.js
|
It checks out, thanks! |
|
🎉 This PR is included in version 3.8.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getPosition has to be called before first setting the state (and thus rendering the tooltip) when
mouse enters, to take into account cases when the position is close to the client window edge
#388