Detach custom event listener #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aronhelser
reviewed
May 21, 2018
src/decorators/customEvent.js
Outdated
| return map[event] | ||
| } | ||
|
|
||
| return void 0 |
There was a problem hiding this comment.
I've not seen this return type before - I'd use 'undefined' if they behave similarly.
src/decorators/customEvent.js
Outdated
| @@ -33,7 +33,27 @@ const setUntargetItems = function (currentTarget, targetArray) { | |||
| } | |||
| } | |||
|
|
|||
| let customListener | |||
| const customListeners = { | |||
| registry: new WeakMap(), | |||
There was a problem hiding this comment.
I'm afraid we won't be able to accept the PR until we can build the standalone with babel-polyfill. Is there a way to use a standard object instead?
There was a problem hiding this comment.
We can define a property on given object. This is how WeakMap is usually polyfilled.
|
Great, the new approach looks reasonable. Can you please add a comment that this is essentially a polyfill for WeakMap? I'll see if I can try it out. |
|
Done. |
|
🎉 This PR is included in version 3.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #370
This PR introduces usage of WeakMap, therefore it may be a breaking change, since WeakMap is unsupported in non-ES6 environments and requires a polyfill.
All projects using babel-polyfill should be unaffected.