Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React 16 support #321

Merged
merged 1 commit into from
Oct 16, 2017
Merged

React 16 support #321

merged 1 commit into from
Oct 16, 2017

Conversation

mikecousins
Copy link
Contributor

No description provided.

@Kerumen
Copy link

Kerumen commented Sep 27, 2017

This won't suffice. See #342.
The code needs to be updated as well.

@mikecousins
Copy link
Contributor Author

Yup, just realized that.

@plemarquand
Copy link

@mikecousins @Kerumen #342 was not a code issue, it stems from having 2 versions of react installed.

@valmassoi
Copy link

valmassoi commented Oct 6, 2017 •
edited
Loading

+1 would be nice to merge so the warnings are killed, package is running nicely on react 16

@jonricaurte jonricaurte mentioned this pull request Oct 10, 2017
Closed
@Jascha-Sundaresan
Copy link

Please merge this

@wwayne
Copy link
Collaborator

wwayne commented Oct 16, 2017

@mikecousins thanks, merging

@wwayne wwayne merged commit a058169 into ReactTooltip:master Oct 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mikecousins @Kerumen @plemarquand @valmassoi @Jascha-Sundaresan @wwayne