Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update position with content #310

Merged
merged 1 commit into from
May 1, 2018
Merged

Update position with content #310

merged 1 commit into from
May 1, 2018

Conversation

stefanhayden
Copy link

When length of content changes in an interval the position never updates when the mouse is still. This causes the positioning of the tooltip to be in the wrong place.

a simple call to this.updatePosition() at the end of this.intervalUpdateContent always keeps the tooltip in the correct position.

CaptEmulation added a commit to CaptEmulation/react-tooltip that referenced this pull request Mar 6, 2018
@aronhelser
Copy link
Collaborator

I like it! I checked it out, and I'm fine with modifying the example.

@aronhelser aronhelser merged commit 3b48785 into ReactTooltip:master May 1, 2018
@stefanhayden
Copy link
Author

thanks! you rock!

@aronhelser
Copy link
Collaborator

🎉 This PR is included in version 3.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@aronhelser
Copy link
Collaborator

This has caused an issue, explained here: #385
We may need to revert unless we can figure out a recursion guard. @stefanhayden would you be able to see if you can reproduce the issue, and possibly fix?

@stefanhayden
Copy link
Author

I'll try and look in to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants