Use prop-types package instead of React.PropTypes #287

ssilve1989 · 2017-04-13T18:54:48Z

In response to warnings appearing when using React 15.5+

audiolion · 2017-04-13T19:43:39Z

package.json

@@ -43,7 +43,8 @@
    "react-dom": "^0.14.0 || ^15.0.0"
  },
  "dependencies": {
-    "classnames": "^2.2.0"
+    "classnames": "^2.2.0",
+    "prop-types": "^15.5.8"


this should be under devDependencies

ssilve1989 · 2017-04-13T19:56:14Z

@audiolion
Actually its suggested to place it in dependencies.

A quote from the library page.

For libraries, we also recommend leaving it in dependencies:

  "dependencies": {
    "prop-types": "^15.5.0" 
  },
  "peerDependencies": {
    "react": "^15.5.0" 
  }

https://www.npmjs.com/package/prop-types

audiolion

Interesting, well ya got me 👍

wwayne · 2017-04-14T03:31:55Z

Yeah thanks @ssilve1989 and @audiolion , merging

ssilve1989 added 2 commits April 13, 2017 14:53

Use prop-types package instead of React.PropTypes

af4a3a2

remove semi-colons to adhere to linting configuration

762ccfe

audiolion suggested changes Apr 13, 2017

View reviewed changes

audiolion approved these changes Apr 13, 2017

View reviewed changes

wwayne merged commit 7390730 into ReactTooltip:master Apr 14, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use prop-types package instead of React.PropTypes #287

Use prop-types package instead of React.PropTypes #287

ssilve1989 commented Apr 13, 2017

audiolion Apr 13, 2017

ssilve1989 commented Apr 13, 2017 •

edited

Loading

audiolion left a comment

wwayne commented Apr 14, 2017

Use prop-types package instead of React.PropTypes #287

Use prop-types package instead of React.PropTypes #287

Conversation

ssilve1989 commented Apr 13, 2017

audiolion Apr 13, 2017

Choose a reason for hiding this comment

ssilve1989 commented Apr 13, 2017 • edited Loading

audiolion left a comment

Choose a reason for hiding this comment

wwayne commented Apr 14, 2017

ssilve1989 commented Apr 13, 2017 •

edited

Loading