Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #256
Hope this PR would fix it once and for all.
Thanks @LeoIannacone for his diagnostics and issue report.
Thanks @tasiek for his extremely helpful diagnostics and feedback about my patch.
Thanks to @gauthierj for his important feedback, I'm glad that this approach OK for him.
Thanks everyone who has faced this issue and test this fix to make sure problem it gone.
Discuss:
Should this library directly depend on
fbjs
?react-dom
is already depends onfbjs
.