Fix delayHide issue #246 #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Really thanks for your work and detailed explanation :), I'm gonna build and release new version, it should be |
|
Very glad to see that you have already reviewed it and pushed it to npm. Thank you! It's important for my project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following text assumes that reader has read description of issue #246.
At first, I've just added
this.cleanTimer()inshowTooltipmethod.Problem described in #246 has completely gone.
But it's reasonable to ask: why behavior is different after
ReactTooltip.rebuild()?It was caused by invalid effect detection in
bindListenersmethod.I think, this should be considered as a bug:
In the example above, there are one
<ReactTooltip />component with default setup, both buttons SampleText(1|2) attached to thisReactTooltip,data-effectof the second button has been set tosolid.I haven't get an idea why
isCaptureis implemented as decorator, but I've followed the same way and have addedgetEffectdecorator. I wonder what you think about it.Tests
Test stand still available at http://hmnid.ru:8090/ . Test stand for
effectissue available at http://hmnid.ru:8090/effect.htmlDemo with fixed react-tooltip available at http://hmnid:8091/ and http://hmnid.ru:8091/effect.html respectively.
Sources of demos available at https://github.com/huumanoid/react-tooltip-delayhide-issue-test