-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some text appears too bold on mobile devices #88
Comments
After some investigation, here's what I found: We set
We also set font-weight bold on elements like We could remove the If the fonts from Monotype don't load for whatever reason, users would be stuck with unbolded type. One workaround would be to use would be to use the CSS Font Loading API, but that seems like a regression since we purposefully got rid of that (FontFaceObserver) in favor of the very simple So, we have to decide how to proceed:
|
I can confirm this also happens on my iPhone. Can we just remove the bold font-weight from the |
Never mind. I see what is going on here. I'll play around with it more i.e. add the "font-weight: normal" as Rebecca suggested originally. The h tags are adding the bold. |
Adding the |
@adamjohnson I see what you mean about the unstyled text flash. But doesn't this happen anyway? It is just more noticeable. Will this hurt our QA score? |
This would not affect our QA scores in Siteimprove. This could have some (probably very minor) impact on our Cumulative Layout Shift scores via Lighthouse. In AG's testing, we're still under the requisite threshold (0.1) with the difference being only 0.03 between the two numbers. I took a look at the Esports and Adventure Well-being Blog to see these changes in action (both use this stock theme). You can throttle your Wi-Fi connection by going to DevTools > Network > Fast 3G to see these changes in a more pronounced manner. Overall, I think this change to the @rebecca-patton and @adamglenn: can either/both of you confirm that the |
On the Adventure Blog site, I'm still seeing the faux-bold on This is less noticeable than the shout text (which is fixed, thank you!), but it's not quite right. I think iowan is okay though? |
@adamjohnson and @adamglenn
I have updated the Planetarium and all appears to look ok. I haven't done any fout and/or lighthouse testing. |
Steps to reproduce the issue
Results
Some of the text looks too chunky (particularly shout). The font weight for wvu-shout text appears bolder on mobile than in a desktop browser. Helvetica-neue-bold text (badges on test page) is also sometimes too bold.
How to fix?
Examples:
Before:
Fixed:
The text was updated successfully, but these errors were encountered: