Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Surface.ofClass(cls) for Scala 3 #2210

Closed
2 of 3 tasks
xerial opened this issue May 31, 2022 · 2 comments
Closed
2 of 3 tasks

Surface.ofClass(cls) for Scala 3 #2210

xerial opened this issue May 31, 2022 · 2 comments
Assignees
@xerial
Labels
enhancement wontfix

Comments

@xerial
Copy link
Member

xerial commented May 31, 2022 •
edited
Loading

This feature is only for Scala JVM.

  • Split the runtime-reflection related code in CompileTimeSurfaceFactory between Scala JVM and JS (e.g., dotty types, TastyReader are not available in Scala.js)
  • Add Surface.ofClass(cls) implementation.
    • This is used in AnyCodec, http code generator. Using TastyReader would work.
    • If Sufarces can be computed at compile-time, AnyCodec(knownSufaces = Seq(...)) can be used after Airframe 22.6.0

After this method is available, we can support Scala 3 in codec, http-code-generator, and parquet, and finally we can complete Scala 3 migration project #1077
@xerial xerial added this to the Scala 3 milestone May 31, 2022
@xerial xerial moved this to Backlog in Airframe Roadmap May 31, 2022
@xerial xerial moved this from Backlog to Planned in Airframe Roadmap May 31, 2022
@xerial xerial self-assigned this Jun 1, 2022
@xerial xerial mentioned this issue Dec 25, 2022
Closed
@xerial
Copy link
Member Author

xerial commented Dec 25, 2022

Deprioritize this work because it will not be required if we support #2667

@xerial xerial added the wontfix label Dec 25, 2022
@xerial xerial removed this from the Scala 3 milestone Dec 25, 2022
@xerial
Copy link
Member Author

xerial commented Aug 4, 2023

No longer need this in Scala 3

@xerial xerial closed this as completed Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xerial xerial

Labels
enhancement wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xerial @exoego