Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS polluting global scope #9

Open
uuf6429 opened this issue Jul 14, 2022 · 1 comment
Open

CSS polluting global scope #9

uuf6429 opened this issue Jul 14, 2022 · 1 comment

Comments

@uuf6429
Copy link

uuf6429 commented Jul 14, 2022

Hey, great tool, however the current css is polluting the global scope with selectors like * or .close etc.

You should define your own vendor scope (say, jsv is a better starting point) and prefix all the selectors with it.

For now I'll just use it without the css and use my own instead.
@haikelfazzani
Copy link
Member

Thanks for reporting! i didn't pay attention ..
would you like to send a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@uuf6429 @haikelfazzani