Cancel processing

[vadimdemedes]

Would be very convenient to be able to cancel processing, if I see it's going too slow and obviously will result in a very large gif (162mb, in my case). My macbook's cooling fan was going like crazy :D

[doot0]

Hey @vdemedes, that sounds like a great idea. Seems silly not to add this. 👍

Took us all less than two minutes to agree on it. Planned!

[danieldelcore]

Hi all, I wouldn't mind giving this issue a shot.
My plan is to store the save / convert action as deferred promise. Then adding a cancel button to the "progress" view, which will resolve the promise and perform all necessary clean up.

Here's a screen grab of my proposed ui change:

[sindresorhus]

I think it would be better to use a cancelable promise. You could use https://github.com/sindresorhus/p-cancelable

[sindresorhus]

And awesome that you want to work on this 🙌

Could you hold off a little bit though? I'm currently doing some large changes, so it would be better if your pull request was based on that.

[danieldelcore]

Great suggestion, thank you! I'll try my best!

[sindresorhus]

@delcore92 I merged my big PR (#186), so you feel free to work on this whenever you see fit :)

[danieldelcore]

Hey guys, i've been picking around this morning, but i can't seem to figure out a nice way to do it. I think this issue might be out of my league because i'm fairly new to electron

[danieldelcore]

I've just raised a PR #189 that includes the small UI change. I would love to get some conversation around how we can approach this issue.

To be honest, i'm a bit lost with the latest refactor. I'm struggling to find a good place to wrap the export process in a cancelable promise.

[skllcrn]

Related to #263