Timeout in DataAccess

[andrew-nowak]

When authorising, we create a DataAccess object, call da.authorise, and wait for it to either emit 'authorised' or 'failed'. But, the request to sentry might hang, or we might get some obscure error which we haven't handled, which means that the original request will also hang indefinitely. Possibly we can create a time out, which will return a 50x and cause an error (possibly kill the server).

[mgcam]

On 07/04/2017 16:54, Andrew Nowak wrote: When authorising, we create a DataAccess object, call da.authorise, and wait for it to either emit 'authorised' or 'failed'. But, the request to sentry might hang,

It is usually possible to set timeout explicitly and is good practice to do so

or we might get some obscure error which we haven't handled,

We only have to handle responses with status 200. For anything else we should log what happened and act as if authorisation was denied.

which means that the original request will also hang indefinitely. Possibly we can create a time out,

there is setTimeout() function on request

which will return a 50x and cause an error

50x is wrong in this case, it's not ranger's error. Normally a request is retried a few times. If everything fails, we just say that authorisation has failed.

(possibly kill the server).

Not sure whether this is a good solution. Might force the whole range set-up down if the network is slow

…

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#175>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACBoRIVHGnws14qxDW6CTioih2MF-5SVks5rtlwcgaJpZM4M3Evf>.

-- The Wellcome Trust Sanger Institute is operated by Genome Research Limited, a charity registered in England with number 1021457 and a company registered in England with number 2742969, whose registered office is 215 Euston Road, London, NW1 2BE.