-
-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jira widget: single-word status does not show #574
Comments
Alternatively, we could change it to match the original proposal's layout: #203 (comment) |
I think either of those are reasonably. Spacing + different colors make the column differences fairly clear from screenshots. |
I think you're right about the cause and your solution sounds good to me. A PR would be appreciated, thanks! |
When implementing the column-based layout as shown in the original proposal (which I personally prefer), I ran into the issue of column widths, as can be seen in this screenshot: This issue already exists if you have longer issue types, as can be seen above as well. Having a lot of varying column positions (as in the screenshot), does not make for an easily scannable display. Having everything in view at a glance is one of the main reasons to use WTF for me personally. I added functionality to first find the longest value in each column, and use that to determine that column's amount of padding. However, there are possible issues with this, mainly the possibility of there being a very long status or type name. I would like the opinion of experienced collaborators on this. I would prefer capping the length at e.g. 16 characters, and cutting off the column contents there. |
My main question for now is:
|
Looks good to me. I think that's a reasonable approach until we can get proper table support for sections like this implemented. |
Fixed by #591 |
What's broken?
If an issue has a name that's only a single word, it's not shown. E.g., we have statusses like
Ready for release
, which is shown.Doing
, however, is hidden.This seems to be caused by the color formatting. I suspect a single word in square brackets (e.g.
[Doing]
) is parsed as a formatter code, and therefore stripped.I've solved this in a local build by replacing the square brackets with parentheses. See attached screenshot.
If this is an acceptable workaround, I'm willing to make a PR for it.
The text was updated successfully, but these errors were encountered: