Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select a GitHub PR to be opened in a browser #547

Closed
Joel-Valentine opened this issue Aug 28, 2019 · 1 comment · Fixed by #586
Closed

Select a GitHub PR to be opened in a browser #547

Joel-Valentine opened this issue Aug 28, 2019 · 1 comment · Fixed by #586
Labels
💥 feature "Good luck, you're gonna need it."

Comments

@Joel-Valentine
Copy link
Contributor

Joel-Valentine commented Aug 28, 2019 •
edited
Loading

What should it do?

When using the GitHub module I would like to be able to select my PR's with the arrow keys/j or k to then open that PR in a browser when hitting the return key.
@Joel-Valentine Joel-Valentine changed the title Select a GitHub PR and open in browser Select a GitHub PR to be opened in a browser Aug 28, 2019
@senorprogrammer senorprogrammer added the 💥 feature "Good luck, you're gonna need it." label Aug 28, 2019
@Joel-Valentine
Copy link
Contributor Author

First off, I'm new to Go. Thinking about working on a PR for this, looking through the existing examples of highlighting from hackernews it looks like ScrollableWidget is a good way to do this. However I have noticed that TextWidget is able to highlight regions.

So I could either retrofit highlighting into the GitHub module or do a bit of a refactor into a ScrollableWidget. What would you guys do? Any advice/suggestions would be greatly appreciated.

@Joel-Valentine Joel-Valentine mentioned this issue Aug 31, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💥 feature "Good luck, you're gonna need it."
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WTF-547 Open selected GitHub PR Joel-Valentine/wtf
2 participants
@senorprogrammer @Joel-Valentine