Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase MulticompartmentSystem onto tree data structure #45

Closed
wsphillips opened this issue Sep 2, 2022 · 1 comment
Closed

Rebase MulticompartmentSystem onto tree data structure #45

wsphillips opened this issue Sep 2, 2022 · 1 comment

Comments

@wsphillips
Copy link
Owner

Instead of starting with an adjacency matrix, build MulticompartmentSystem on a tree data structure (potentially AbstractTrees.jl interface). It will be more robust for equation building, and it should eliminate the need to depend on parent references directly in CompartmentSystem.

Later, during lowering, we will likely transform to an adjacency matrix for PDE Cable equation modeling. Again, having a tree to start from will make this easier since a Hines matrix is a depth first search on a dendritic tree.

@wsphillips
Copy link
Owner Author

I tried this but ran into issues with updating tree structures. Specifically, when adding postsynaptic conductances, you wind up breaking pointers to child branches. It might be solved with a more sophisticated/clever implementation, but for now its not worth the added effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant