Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(console): SAML IdP attributes validation #2366

Merged
merged 3 commits into from
Aug 20, 2021
Merged

fix(console): SAML IdP attributes validation #2366

merged 3 commits into from
Aug 20, 2021

Conversation

yasinmiran
Copy link
Contributor

@yasinmiran yasinmiran commented Aug 18, 2021 •
edited
Loading

Purpose

Please note $subject. This PR fixes mainly 3 issues. Including some source code improvements.

Default Changelist

  • Fix: Unable to update Identity Provider attributes with the same name in Enterprise IDP with SAML protocol configuration.
  • Fix: Error popup tooltip does not get appeared when there's an error.
  • Change ambiguous description of enterprise IdP (OIDC & SAML)

Improvements

  • Fully ported the AttributeMappingListItem component to use @wso2is/form module APIs.
  • Conditional logic changes.

Related Issues

  • Issue #1 or (None)

Checklist

  • e2e cypress tests locally verified.
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there's any)
  • Unit tests provided. (Add links if there's any)
  • Integration tests provided. (Add links if there's any)

Related PRs

  • Related PR #1 or (None)

Security checks

@yasinmiran
Change Enterprise IdP creation default descriptions.
db0167e 
Note that this closes cloud 5761 and only affects to
newly creating IdPs. Existing IdPs will still have the
same description.
@yasinmiran
Re implement attribute claims validation logic.
cb87336 
This addresses the cloud issue 4194 and 4174
QA-Rejected Task 2 (in comment id 895763102).
Now it properly validates the already mapped
value before adding it to the list and show the
proper error messages popups.
@yasinmiran
Improve prop conditional logic
07533e7
@yasinmiran yasinmiran merged commit 6b6c958 into wso2:master Aug 20, 2021
wso2-jenkins-bot pushed a commit that referenced this pull request Jul 23, 2024
@github-actions
[WSO2 Release] [GitHub Action #2366] [Release] [skip ci] prepare rele…
5446c32 
…ase identity-apps-console-2.21.17
wso2-jenkins-bot pushed a commit that referenced this pull request Jul 23, 2024
@github-actions
[WSO2 Release] [GitHub Action #2366] [Release] [skip ci] prepare for …
65d5975 
…next development iteration
wso2-jenkins-bot pushed a commit that referenced this pull request Jul 23, 2024
@github-actions
[WSO2 Release] [GitHub Action #2366] [Release] [skip ci] prepare rele…
6976c71 
…ase identity-apps-myaccount-2.7.84
wso2-jenkins-bot pushed a commit that referenced this pull request Jul 23, 2024
@github-actions
[WSO2 Release] [GitHub Action #2366] [Release] [skip ci] prepare for …
90e426b 
…next development iteration
wso2-jenkins-bot pushed a commit that referenced this pull request Jul 23, 2024
@github-actions
[WSO2 Release] [GitHub Action #2366] [Release] [skip ci] Merge releas…
0717e73 
…e branch release-action-2366
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brionmario brionmario brionmario approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yasinmiran @brionmario