Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Preliminary Version of the Guideline Document for Update Propagation #2

Merged
merged 9 commits into from
Jul 9, 2020

Conversation

chirangaalwis
Copy link
Member

Purpose

This PR addresses #1.

Goals

Introduce Preliminary Version of the Guideline Document for Update Propagation

* Updates to configuration files and non-configuration artifacts (e.g. binaries such as, third-party libraries,
Carbon extensions in the form of OSGi bundles, [Carbon Applications](https://docs.wso2.com/display/Carbon440/Working+with+Carbon+Applications)
or any security related artifacts such as, Java Keystore files)
* Integrate changes to the container image source
Copy link
Contributor

@chamindi-a chamindi-a Jun 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include changes to the container image source

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chamindi-a I think we should stick to the verb Integrate here, as Include actually does not imply the meaning, i.e. to perform a change to container image source and deploy it.

Further, this is applicable to the next point which is about installation resources as well.

WDYT?

Copy link
Contributor

@chamindi-a chamindi-a Jun 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chirangaalwis: I have tried a change as the same verb was used in three instances. if we can change this iam ok

@chirangaalwis
Copy link
Member Author

@chamindi-a I have updated the PR with the requested changes, as of now.

The prime reason for adopting rolling update strategy is its ability to perform an update with zero downtime.

**Notes:**
> Apart from the rolling update strategy, we adopt [`OnDelete`](https://kubernetes.io/docs/tutorials/stateful-application/basic-stateful-set/#on-delete)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DilanUA @ThilinaManamgoda as per the internal discussion this needs to be changed. Will update this after further testing of the discussed scenario.

@chirangaalwis chirangaalwis force-pushed the container-guide-update-strategy branch from 668e40e to 65de83d Compare July 8, 2020 18:02
@DilanUA DilanUA merged commit 2b9241b into wso2:master Jul 9, 2020
@chirangaalwis chirangaalwis linked an issue Jul 29, 2020 that may be closed by this pull request
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce Guideline Document for Update Propagation
3 participants