Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bluesky-cmds has fallen behind dependencies: pin versions? #61

Open
wright-stuff opened this issue Oct 17, 2024 · 1 comment
Open

bluesky-cmds has fallen behind dependencies: pin versions? #61

wright-stuff opened this issue Oct 17, 2024 · 1 comment

Comments

@wright-stuff
Copy link
Contributor

wright-stuff commented Oct 17, 2024

e.g. bluesky_queueserver_api.REManagerAPI has changed its kwargs in the last two years, which breaks our current arguments

https://github.com/bluesky/bluesky-queueserver-api/blame/cf80c4c4d3383b76d805c090fb5d3bd41b07233f/bluesky_queueserver_api/zmq/aio.py#L16

This could probably be fixed pretty easily, but there is no telling what other issues remain...

@ddkohler
Copy link
Contributor

I was not able to reproduce this issue. Inspection of code shows that the change in REManager kwargs is already handled in our code. I think the issue I had was an improper config file (note that zmqproxy needs a different address format than the other 3 ports.

Corrective actions:

  • REMOVE bluesky version pins
  • make sure config defaults still work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants