Skip to content
This repository has been archived by the owner on Oct 8, 2019. It is now read-only.

Thrift API unpack function #72

Open
eightysteele opened this issue Jul 11, 2012 · 0 comments
Open

Thrift API unpack function #72

eightysteele opened this issue Jul 11, 2012 · 0 comments
Labels

Comments

@eightysteele
Copy link
Contributor

We've surfaced a new Thrift API in feature/thrift-api which includes an unpack function for unpacking any Thrift object. There's a few concerns about this.

Basically Thrift objects don't really have ordering by default, so what should you get back when unpacking? Consider an IDL struct like this:

struct TimeValue {
  1: i32 timestamp
  2: optional string title
  5: i64 value
}

We need to make sure unpack responds consistently for populated and un-populated fields. Also instead of hardcoding unpack implementations, we should reflect on the class to get field names. It should "just work" for any Thrift object.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant