You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 8, 2019. It is now read-only.
We've surfaced a new Thrift API in feature/thrift-api which includes an unpack function for unpacking any Thrift object. There's a few concerns about this.
Basically Thrift objects don't really have ordering by default, so what should you get back when unpacking? Consider an IDL struct like this:
struct TimeValue {
1: i32 timestamp
2: optional string title
5: i64 value
}
We need to make sure unpack responds consistently for populated and un-populated fields. Also instead of hardcoding unpack implementations, we should reflect on the class to get field names. It should "just work" for any Thrift object.
The text was updated successfully, but these errors were encountered:
We've surfaced a new Thrift API in feature/thrift-api which includes an
unpack
function for unpacking any Thrift object. There's a few concerns about this.Basically Thrift objects don't really have ordering by default, so what should you get back when unpacking? Consider an IDL struct like this:
We need to make sure
unpack
responds consistently for populated and un-populated fields. Also instead of hardcodingunpack
implementations, we should reflect on the class to get field names. It should "just work" for any Thrift object.The text was updated successfully, but these errors were encountered: