make _loadFromServer respect the base_url setting #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tubaman
force-pushed
the
loadFromServer_base_url
branch
from
dadaa21 to
470eb7e
Compare
|
I think the CI failure above has to due with a race condition with the phantomjs-based testing. I had similiar issues when running the tests locally. |
|
Thanks, this would be good to have. I integrated a newer testing library (jest) as part of #109. Could you rebase this PR off of the latest master? |
Make _loadFromServer respect the base_url setting. That way when we serve wq from a non-root(/) path, the routing works correctly. For example, try.wq.io "View All Observations" 404s without this.
sheppard
force-pushed
the
loadFromServer_base_url
branch
from
470eb7e to
0e49b1e
Compare
|
Never mind, I was able to rebase and push to your branch. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make _loadFromServer respect the base_url setting. That way when we
serve wq from a non-root(/) path, the routing works correctly. For
example, try.wq.io "View All Observations" 404s without this.